[Django] #26097: UserCreationForm isn't using password_validators_help_text_html
Django
------------------------------+--------------------
Reporter: ataylor32 | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------
Unlike `SetPasswordForm` and `AdminPasswordChangeForm`, `UserCreationForm`
is not using `password_validators_help_text_html`. I think this was
probably accidentally left out of #25052. This means that the "Add user"
form at /admin/auth/user/add/ provides no indication of what the password
requirements are unless you provide a password that does not pass
validation. Even then, it doesn't list what ''all'' of the password
requirements are.
I tried adding
`help_text=password_validation.password_validators_help_text_html()` to
the `UserCreationForm` form's `password1` field, but the CSS didn't work
well with this (see the attached screen shot), so now I'm submitting this
ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/26097>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: ataylor32 | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 1.9
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 0 |
Changes (by ataylor32):
* Attachment "add-user-password-help-text-misaligned.png" added.
Django
Reporter: ataylor32 | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 1.9
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26097#comment:1>
Django
Reporter: ataylor32 | Owner: sasha0
Type: Bug | Status: assigned
Component: contrib.auth | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sasha0):
* status: new => assigned
* owner: nobody => sasha0
--
Ticket URL: <https://code.djangoproject.com/ticket/26097#comment:2>
Django
Reporter: ataylor32 | Owner: sasha0
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by sasha0):
Replying to [comment:1 timgraham]:
Could you please submit empty "Add user" and "Password change" forms in
the admin?
There might be also another styling issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/26097#comment:3>
Django
Reporter: ataylor32 | Owner: sasha0
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by sasha0):
* has_patch: 0 => 1
Comment:
Found incorrect indent for lists in the wide fieldsets - fixed it too.
[https://github.com/django/django/pull/6031 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/26097#comment:4>
Django
Reporter: ataylor32 | Owner: sasha0
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
I'm not sure about the proposal on the pull request to change `<p>` tags
to `<span>` in order to allow `help_text` to contain `<ul>`. This might
be a bit disruptive for anyone extending the admin with custom markup or
CSS. I don't have a good solution in mind but suggested to write to the
DevelopersMailingList to get feedback on this before we proceed with it.
Marking "Patch needs improvement" as an indication of that need.
--
Ticket URL: <https://code.djangoproject.com/ticket/26097#comment:5>
Django
Reporter: ataylor32 | Owner: sasha0
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by sasha0):
Asked about this in [https://groups.google.com/forum/#!topic/django-
developers/nAk3zrMDeNc mailing list].
--
Ticket URL: <https://code.djangoproject.com/ticket/26097#comment:6>
Django
Reporter: ataylor32 | Owner: sasha0
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26097#comment:7>
Django
Reporter: ataylor32 | Owner: sasha0
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26097#comment:8>
Django
Reporter: ataylor32 | Owner: sasha0
Component: contrib.auth | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"536db42cf01ebe0dd633b131c3dbfc0bf743064f" 536db42]:
{{{
#!CommitTicketReference repository=""
revision="536db42cf01ebe0dd633b131c3dbfc0bf743064f"
Fixed #26097 -- Added password_validators_help_text_html to
UserCreationForm.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26097#comment:9>