[Django] #22308: Transaction-related test failures on MySQL

Django

unread,

Mar 21, 2014, 5:38:19 PM3/21/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Component: Database | Version: master
layer (models, ORM) | Keywords:
Severity: Normal | Has patch: 0
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Some tests that relied on internals of the legacy transaction management
system fail after 0f956085.

I must have ported them incorrectly or introduced regressions. This is a
release blocker for 1.8.

--
Ticket URL: <https://code.djangoproject.com/ticket/22308>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Mar 21, 2014, 5:38:24 PM3/21/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------

* status: new => assigned
* owner: nobody => aaugustin

--
Ticket URL: <https://code.djangoproject.com/ticket/22308#comment:1>

Django

unread,

Mar 21, 2014, 5:39:49 PM3/21/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------

Comment (by aaugustin):

The three test failures I'm talking about are shown here:
http://ci.djangoproject.com/job/Django/database=mysql,python=python2.7/4219/testReport/

--
Ticket URL: <https://code.djangoproject.com/ticket/22308#comment:2>

Django

unread,

Mar 22, 2014, 6:06:00 AM3/22/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------

Comment (by Aymeric Augustin <aymeric.augustin@…>):

In [changeset:"0757e0f30d5ad3731d4a59fe571256369663c2f6"]:
{{{
#!CommitTicketReference repository=""
revision="0757e0f30d5ad3731d4a59fe571256369663c2f6"
Avoided transactional DDL on castrated databases.

Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22308#comment:3>

Django

unread,

Mar 22, 2014, 9:40:02 AM3/22/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------

Comment (by Aymeric Augustin <aymeric.augustin@…>):

In [changeset:"6877a9d4156baa3a0c22288c7ef920915b6e1cf8"]:
{{{
#!CommitTicketReference repository=""
revision="6877a9d4156baa3a0c22288c7ef920915b6e1cf8"
Avoided transactional truncates on amateur databases.

Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22308#comment:4>

Django

unread,

Mar 22, 2014, 4:20:13 PM3/22/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------

Comment (by aaugustin):

The remaining failure comes from the test introduced in 2416e5fefe to fix
#9479.

--
Ticket URL: <https://code.djangoproject.com/ticket/22308#comment:5>

Django

unread,

Mar 22, 2014, 4:36:25 PM3/22/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------

Reporter: aaugustin | Owner: aaugustin
Type: Bug | Status: closed

Component: Database layer | Version: master

(models, ORM) | Resolution: fixed

Changes (by Aymeric Augustin <aymeric.augustin@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"b66e85342b6ab28b7f48b47fe3fcfbccd5d9943f"]:
{{{
#!CommitTicketReference repository=""
revision="b66e85342b6ab28b7f48b47fe3fcfbccd5d9943f"
Fixed #22308 -- Regression from 0f956085.

Rewrote the test for #9479 according to the original ticket.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22308#comment:6>

Django

unread,

Jul 24, 2014, 6:49:38 PM7/24/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"2a97db33a79c0be179b5bc35860400287f1ae26a"]:
{{{
#!CommitTicketReference repository=""
revision="2a97db33a79c0be179b5bc35860400287f1ae26a"
[1.7.x] Avoided transactional DDL on castrated databases.

Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308 and #23089.

Backport of 0757e0f30d from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22308#comment:7>

Django

unread,

Jul 24, 2014, 7:19:52 PM7/24/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"0ac986fd8cb2561a22aa3291672723b50397e5ac"]:
{{{
#!CommitTicketReference repository=""
revision="0ac986fd8cb2561a22aa3291672723b50397e5ac"
[1.7.x] Avoided transactional truncates on amateur databases.

Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308.

Backport of 6877a9d4 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/22308#comment:8>

Django

unread,

Jul 24, 2014, 7:55:55 PM7/24/14

to django-...@googlegroups.com

#22308: Transaction-related test failures on MySQL
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"83098dccdf3172302cde54e11c36050c1d83f996"]:
{{{
#!CommitTicketReference repository=""
revision="83098dccdf3172302cde54e11c36050c1d83f996"
[1.6.x] Fixed #23089 -- Fixed transaction handling in two management
commands.

Previously, when createcachetable and flush operated on non-default
databases, they weren't atomic.

Also avoided transactional DDL and transactional truncates on databases
that don't support them (refs #22308).