[Django] #32395: Migrate signals verbose stdout emissions are not capturable

22 views
Skip to first unread message

Django

unread,
Jan 29, 2021, 10:18:43 AM1/29/21
to django-...@googlegroups.com
#32395: Migrate signals verbose stdout emissions are not capturable
------------------------------------------------+------------------------
Reporter: Simon Charette | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 3.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The `migrate` command takes a `--verbosity` flag that is passed down to
`emit_pre_migrate_signal` and `emit_post_migrate_signal` functions but
these are not provided which `stdout` the output should be directed to.
This makes testing `migrate -v2` through `call_command` pollute
`sys.stdout` when it should be directed to the provided `stdout` as
discovered in
https://github.com/django/django/pull/13890#pullrequestreview-579320176

--
Ticket URL: <https://code.djangoproject.com/ticket/32395>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 29, 2021, 10:28:05 AM1/29/21
to django-...@googlegroups.com
#32395: Migrate signals verbose stdout emissions are not capturable
-------------------------------------+-------------------------------------

Reporter: Simon Charette | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Migrations | Version: 3.1
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/32395#comment:1>

Django

unread,
Jan 29, 2021, 2:53:19 PM1/29/21
to django-...@googlegroups.com
#32395: Migrate signals verbose stdout emissions are not capturable
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Simon
Type: | Charette
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Simon Charette
* status: new => assigned
* version: 3.1 => master
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/32395#comment:2>

Django

unread,
Feb 2, 2021, 8:02:45 AM2/2/21
to django-...@googlegroups.com
#32395: Migrate signals verbose stdout emissions are not capturable
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Simon
Type: | Charette
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_docs: 0 => 1


Comment:

[https://github.com/django/django/pull/13952 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/32395#comment:3>

Django

unread,
Feb 3, 2021, 11:48:13 PM2/3/21
to django-...@googlegroups.com
#32395: Migrate signals verbose stdout emissions are not capturable
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Simon
Type: | Charette
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* needs_docs: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/32395#comment:4>

Django

unread,
Feb 4, 2021, 1:22:55 AM2/4/21
to django-...@googlegroups.com
#32395: Migrate signals verbose stdout emissions are not capturable
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Simon
Type: | Charette
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32395#comment:5>

Django

unread,
Feb 4, 2021, 5:49:10 AM2/4/21
to django-...@googlegroups.com
#32395: Migrate signals verbose stdout emissions are not capturable
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Simon
Type: | Charette
Cleanup/optimization | Status: closed
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"f23b05696e470fc113c729e18665722ccbb7a9f0" f23b056]:
{{{
#!CommitTicketReference repository=""
revision="f23b05696e470fc113c729e18665722ccbb7a9f0"
Fixed #32395 -- Allowed capturing stdout of migration signals.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32395#comment:6>

Reply all
Reply to author
Forward
0 new messages