[Django] #29483: Confirm support for GDAL 2.3
Django
------------------------------------------------+------------------------
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
I see a number of test failures with GDAL 2.3 (attached) but as in #28257,
it might merely be a problem on my machine.
--
Ticket URL: <https://code.djangoproject.com/ticket/29483>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* Attachment "gdal-2.3-failures.txt" added.
Django
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* Attachment "29483-docs.diff" added.
Django
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz):
I just compiled a fresh 2.3 and obtained those 2 failures only:
{{{
======================================================================
FAIL: test_poly_multi (gis_tests.inspectapp.tests.OGRInspectTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/claude/checkouts/django-
git/tests/gis_tests/inspectapp/tests.py", line 91, in test_poly_multi
self.assertIn('geom = models.MultiLineStringField(srid=-1)',
model_def)
AssertionError: 'geom = models.MultiLineStringField(srid=-1)' not found in
'# This is an auto-generated Django model module created by
ogrinspect.\nfrom django.contrib.gis.db import models\n\n\nclass
MyModel(models.Model):\n laenge = models.FloatField()\n breite =
models.FloatField()\n nummer = models.BigIntegerField()\n geom =
models.MultiLineStringField(srid=31253)'
======================================================================
FAIL: test05_geometries (gis_tests.gdal_tests.test_ds.DataSourceTest)
Testing Geometries from Data Source Features.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/claude/checkouts/django-
git/tests/gis_tests/gdal_tests/test_ds.py", line 230, in test05_geometries
self.assertIsNotNone(re.match(wgs_84_wkt_regex, g.srs.wkt))
AssertionError: unexpectedly None
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29483#comment:1>
Django
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz):
This [https://github.com/django/django/pull/10037 PR] is solving the WGS
84 regex. I have no idea for the other failure, how GDAL can find a 31253
srid.
Note also that we should drop official support for GDAL 1.9 and 1.10 at
least.
--
Ticket URL: <https://code.djangoproject.com/ticket/29483#comment:2>
Django
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"86988dd890671aa8935f86eab2bbe22ad917db70" 86988dd]:
{{{
#!CommitTicketReference repository=""
revision="86988dd890671aa8935f86eab2bbe22ad917db70"
Refs #29483 -- Relaxed WGS 84 check regex
With GDAL 2.3, the exact string changed again.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29483#comment:3>
Django
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"69e2d173e5082a8c475586cff7920b2fb962c333" 69e2d173]:
{{{
#!CommitTicketReference repository=""
revision="69e2d173e5082a8c475586cff7920b2fb962c333"
[2.1.x] Refs #29483 -- Relaxed WGS 84 check regex
With GDAL 2.3, the exact string changed again.
Backport of 86988dd890671aa8935f86eab2bbe22ad917db70 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29483#comment:4>
Django
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: 2.0
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* has_patch: 0 => 1
Comment:
"EPSG:31253 Projected coordinate system for Austria east of 14°50'E of
Greenwich (32°30'E of Ferro)." seems to make sense given a mention of
Austria in the
[https://github.com/django/django/blob/2bc014750adb093131f77e4c20bc17ba64b75cac/tests/gis_tests/data/gas_lines/gas_leitung.prj
gas_leitung] test data file.
[https://github.com/django/django/pull/10045 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/29483#comment:5>
Django
Reporter: Tim Graham | Owner: nobody
Cleanup/optimization |
Component: GIS | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* stage: Accepted => Ready for checkin
Comment:
Ahhh.. I didn't notice that the second part of the test was using
`gas_leistung.shp`. Makes sense now.
--
Ticket URL: <https://code.djangoproject.com/ticket/29483#comment:6>
Django
Reporter: Tim Graham | Owner: nobody
Cleanup/optimization |
Component: GIS | Version: 2.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"9e4f26bb40abcade301ec836aa0b84acf5f60041" 9e4f26bb]:
{{{
#!CommitTicketReference repository=""
revision="9e4f26bb40abcade301ec836aa0b84acf5f60041"
Fixed #29483 -- Confirmed support for GDAL 2.3.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29483#comment:7>