[Django] #23303: sqlmigrate doesn't output BEGIN and COMMIT statements
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.7-beta-2
Component: Core | Keywords:
(Management commands) | Has patch: 0
Severity: Normal | Needs tests: 0
Triage Stage: | Easy pickings: 0
Unreviewed |
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
All other `sql*` commands wrap their output in `BEGIN; ... COMMIT;`
statements.
PR here: https://github.com/django/django/pull/3076
--
Ticket URL: <https://code.djangoproject.com/ticket/23303>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Type: | Status: new
Component: Core (Management | Resolution:
commands) | Triage Stage: Accepted
Severity: Release blocker | Needs documentation: 0
Keywords: | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timgraham):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* version: 1.7-beta-2 => 1.7-rc-2
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/23303#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Type: | Status: new
Component: Core (Management | Resolution:
Severity: Release blocker | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timgraham):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/23303#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Cleanup/optimization | Version: 1.7-rc-2
Component: Core (Management | Resolution: fixed
commands) | Triage Stage: Ready for
Severity: Release blocker | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"5853c87a458f62ebd62d7809168355610de2570c"]:
{{{
#!CommitTicketReference repository=""
revision="5853c87a458f62ebd62d7809168355610de2570c"
Fixed #23303 -- Added BEGIN and COMMIT statements to the output of
sqlmigrate.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23303#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Cleanup/optimization | Version: 1.7-rc-2
Component: Core (Management | Resolution: fixed
commands) | Triage Stage: Ready for
Severity: Release blocker | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Baptiste Mispelon <bmispelon@…>):
In [changeset:"3a80189479a29220bac6d205a1b97184bd76a876"]:
{{{
#!CommitTicketReference repository=""
revision="3a80189479a29220bac6d205a1b97184bd76a876"
[1.7.x] Fixed #23303 -- Added BEGIN and COMMIT statements to the output of
sqlmigrate.
Backport of 5853c87a458f62ebd62d7809168355610de2570c from master.
Conflicts:
django/core/management/commands/sqlmigrate.py
tests/user_commands/tests.py
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23303#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Type: | Status: new
Component: Core (Management | Resolution:
Severity: Release blocker | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: closed => new
* resolution: fixed =>
Comment:
One minor issue with the tests: Oracle doesn't include `BEGIN;` in its
transactions.
--
Ticket URL: <https://code.djangoproject.com/ticket/23303#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Type: | Status: new
Component: Core (Management | Resolution:
commands) | Triage Stage: Ready for
Severity: Release blocker | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Baptiste Mispelon <bmispelon@…>):
In [changeset:"54164b814cab71a8a0503743befbdcc99ae6c7a0"]:
{{{
#!CommitTicketReference repository=""
revision="54164b814cab71a8a0503743befbdcc99ae6c7a0"
Fixed broken tests on Oracle after
5853c87a458f62ebd62d7809168355610de2570c.
Oracle doesn't have a `BEGIN` statement so the test would
fail.
Refs #23303
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23303#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Type: | Status: new
Component: Core (Management | Resolution:
commands) | Triage Stage: Ready for
Severity: Release blocker | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Baptiste Mispelon <bmispelon@…>):
In [changeset:"24d9aee1880ced5892af42f35539a5d705adf512"]:
{{{
#!CommitTicketReference repository=""
revision="24d9aee1880ced5892af42f35539a5d705adf512"
[1.7.x] Fixed broken tests on Oracle after
5853c87a458f62ebd62d7809168355610de2570c.
Oracle doesn't have a `BEGIN` statement so the test would
fail.
Refs #23303
Backport of 54164b814cab71a8a0503743befbdcc99ae6c7a0 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23303#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Type: | Status: new
Component: Core (Management | Resolution:
commands) | Triage Stage: Ready for
Severity: Release blocker | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by andrewgodwin):
Why is this reopened? It looks like the other DBs will still get BEGIN/END
--
Ticket URL: <https://code.djangoproject.com/ticket/23303#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: bmispelon | Owner: nobody
Cleanup/optimization | Version: 1.7-rc-2
Component: Core (Management | Resolution: fixed
commands) | Triage Stage: Ready for
Severity: Release blocker | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
Sorry, I forgot to close it again after
54164b814cab71a8a0503743befbdcc99ae6c7a0.
--
Ticket URL: <https://code.djangoproject.com/ticket/23303#comment:9>