[Django] #27175: Deprecate silencing exceptions raised while rendering the {% include %} template tag
Django
template tag
------------------------------------------------+------------------------
Reporter: jdufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Template system | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Django developers discussion https://groups.google.com/d/topic/django-
developers/hscW1VboJxY
As proposed and supported in the linked discussion, deprecate the
silencing of exceptions while rending the `{% include %}` template tag.
As this silencing behavior only occurs when `template.debug=True`, it is
difficult to rely on this as a "feature". Further, the behavior could
silence actual bugs during development as well as lead to a different
error reporting path when used in production. (e.g. Errors are reported
through Django template logging instead of through Sentry.)
--
Ticket URL: <https://code.djangoproject.com/ticket/27175>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
template tag
Reporter: jdufresne | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Template system | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jdufresne):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/7208 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/27175#comment:1>
Django
template tag
Reporter: jdufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Template system | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/27175#comment:2>
Django
template tag
Reporter: jdufresne | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Template system | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/27175#comment:3>
Django
template tag
Reporter: jdufresne | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Template system | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"331ca5391eb64cbac3a001209257beb93522d587" 331ca53]:
{{{
#!CommitTicketReference repository=""
revision="331ca5391eb64cbac3a001209257beb93522d587"
Fixed #27175 -- Deprecated silencing exceptions from the {% include %}
template tag.
Thanks Tim Graham for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27175#comment:4>
Django
template tag
Reporter: Jon Dufresne | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Template system | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"e62165b898785e890661953c3b2c9c36d98aee57" e62165b]:
{{{
#!CommitTicketReference repository=""
revision="e62165b898785e890661953c3b2c9c36d98aee57"
Refs #27175 -- Removed exception silencing from the {% include %} template
tag.
Per deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27175#comment:5>
Django
template tag
Reporter: Jon Dufresne | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"058d112ed2635873d415661bdf0fcc8752ec37c9" 058d112]:
{{{
#!CommitTicketReference repository=""
revision="058d112ed2635873d415661bdf0fcc8752ec37c9"
Refs #27175 -- Removed an obsolete test comment and DEBUG=True.
As of e62165b898785e890661953c3b2c9c36d98aee57, {% include %}
doesn't silence exceptions.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27175#comment:6>