[Django] #24286: Move django.core.files.locks to django.utils.locks
Django
------------------------------------------------+------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Utilities | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
It's just a set of utilities and it isn't documented.
--
Ticket URL: <https://code.djangoproject.com/ticket/24286>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by timgraham):
* version: 1.7 => master
* easy: 0 => 1
* stage: Unreviewed => Accepted
Comment:
My only concern is that `django.utils.locks` doesn't indicate these are
*file* locks.
--
Ticket URL: <https://code.djangoproject.com/ticket/24286#comment:1>
Django
Reporter: aaugustin | Owner: gmunumel
Type: Cleanup/optimization | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
* owner: nobody => gmunumel
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24286#comment:2>
Django
Reporter: aaugustin | Owner: gmunumel
Type: Cleanup/optimization | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Comment (by gmunumel):
Hello. I would like to do this change. What exactly I need to change?
--
Ticket URL: <https://code.djangoproject.com/ticket/24286#comment:3>
Django
Reporter: aaugustin | Owner: gmunumel
Type: Cleanup/optimization | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Comment (by gmunumel):
I have an error in the docs validation, any idea?
https://github.com/django/django/pull/4146
--
Ticket URL: <https://code.djangoproject.com/ticket/24286#comment:4>
Django
Reporter: aaugustin | Owner: gmunumel
Type: Cleanup/optimization | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Comment (by gmunumel):
New PR added:
https://github.com/gmunumel/django/commit/9f63fad5e29a6b093e951ee10a5f4f4d2fc9e8a5
--
Ticket URL: <https://code.djangoproject.com/ticket/24286#comment:5>
Django
Reporter: aaugustin | Owner: gmunumel
Type: Cleanup/optimization | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Comment (by timgraham):
I'm less enthusiastic about the idea after seeing
`django/core/files/move.py` which is a file utility that only relies on
locks (but documented) and #20488 which adds `django/core/files/copy.py`
which also seems suitable for `utils`. I guess most of `django.core.files`
could go in `utils` if we had to do it over again, but not sure there's
much benefit in splitting things now. Aymeric, did you have any more
motivation than what you stated in the ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/24286#comment:6>
Django
Reporter: aaugustin | Owner: gmunumel
Type: Cleanup/optimization | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Comment (by aaugustin):
No. I just filed the ticket as I came across the module and it seemed
misplaced. I didn't investigate much.
--
Ticket URL: <https://code.djangoproject.com/ticket/24286#comment:7>
Django
Reporter: aaugustin | Owner: gmunumel
Component: Utilities | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
* status: assigned => closed
* resolution: => wontfix
--
Ticket URL: <https://code.djangoproject.com/ticket/24286#comment:8>