[Django] #23842: Transient failure of django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
-------------------------------------+------------------------
Reporter: charettes | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+------------------------
{{{
Traceback (most recent call last):
File "/home/jenkins/workspace/django-
master/database/postgis/python/python3.2/django/test/testcases.py", line
959, in skip_wrapper
return test_func(*args, **kwargs)
File "/home/jenkins/workspace/django-
master/database/postgis/python/python3.2/django/contrib/gis/tests/geoapp/tests.py",
line 632, in test_make_line
self.assertTrue(ref_line.equals_exact(City.objects.make_line(),
tolerance=10e-5))
AssertionError: False is not true
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23842>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: charettes | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by tchaumeny):
That looks like a floating point error due to the underlying library
implementation. This test used to fail more often before `tolerance` was
added (see also
https://github.com/django/django/commit/9f576dd54fafdd76aa250f8947cc76c7ae19216c).
Can you reproduce the failure on your machine ? — I can't on mine even if
I run the test a hundred time.
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:1>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: charettes | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
Couldn't reproduce locally with 80 tries... I suggest we keep this ticket
open as a reference until we figure out how to deal with this.
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:2>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: charettes | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
I suspect an issue with ordering, but simply adding an `order_by()` will
not be enough. The ST_MakeLine documentation suggests to solve this by
using the PostgreSQL 9+ ORDER BY support for aggregates. So the proper fix
might not be trivial.
http://postgis.net/docs/ST_MakeLine.html
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:3>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: charettes | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by tchaumeny):
That might be an explanation. What about adding some message like
`self.assertTrue(ref_line.equals_exact(line, tolerance=10e-5), "%s != %s"
% (ref_line, line))` so that we can see the actual differences ?
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:4>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: charettes | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"fc3643743456e98ceb902ee1e48c1bc5f56034cf"]:
{{{
#!CommitTicketReference repository=""
revision="fc3643743456e98ceb902ee1e48c1bc5f56034cf"
Added assertion error message for test_make_line
Refs #23842. Thanks Thomas Chaumeny for the suggestion.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:5>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: charettes | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by tchaumeny):
* cc: t.chaumeny@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:6>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: worksforme
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* status: new => closed
* resolution: => worksforme
Comment:
I haven't seen this failure recently.
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:7>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* status: closed => new
* resolution: worksforme =>
Comment:
I saw this on Jenkins (a pull request to the master branch) today.
{{{
File "python3.6/tests/gis_tests/geoapp/tests.py", line 540, in
test_make_line
"%s != %s" % (ref_line, line)
AssertionError: False is not true :
SRID=4326;LINESTRING (-95.363151 29.763374, -96.80161099999999 32.782057,
-97.521157 34.464642, 174.783117 -41.315268, -104.609252 38.255001,
-95.23506 38.971823, -87.650175 41.850385, -123.305196 48.462611)
!=
SRID=4326;LINESTRING (-104.609252 38.255001, -95.23506 38.971823,
-87.650175 41.850385, -123.305196 48.462611, -95.363151 29.763374,
-96.80161099999999 32.782057, -97.521157 34.464642, 174.783117 -41.315268)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:8>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: dev
Severity: Normal | Resolution: worksforme
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* status: new => closed
* resolution: => worksforme
Comment:
I haven't seen this failure in the last 2-3 years.
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:9>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* status: closed => new
* resolution: worksforme =>
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:10>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak):
It started failing again:
{{{
False is not true : SRID=4326;LINESTRING (-95.363151 29.763374,
-96.80161099999999 32.782057, -97.521157 34.464642, 174.783117 -41.315268,
-104.609252 38.255001, -95.23506 38.971823, -87.650175 41.850385,
-123.305196 48.462611) != SRID=4326;LINESTRING (-87.650175 41.850385,
-123.305196 48.462611, -95.363151 29.763374, -96.80161099999999 32.782057,
-97.521157 34.464642, 174.783117 -41.315268, -104.609252 38.255001,
-95.23506 38.971823)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:11>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: Simon Charette | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* owner: nobody => Mariusz Felisiak
* status: new => assigned
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/16419 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:12>
Django
django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest.test_make_line
Reporter: Simon Charette | Owner: Mariusz
| Felisiak
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"6774e9359cbdbf7b8c448597c103288ac381519a" 6774e935]:
{{{
#!CommitTicketReference repository=""
revision="6774e9359cbdbf7b8c448597c103288ac381519a"
Fixed #23842 -- Fixed flaky GeoQuerySetTest.test_make_line() test.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23842#comment:13>