[Django] #26125: Fix E731 flake warnings (do not assign a lambda expression, use a def)
Django
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
A patch is attached to get started. Just run flake8 in the root clone
directory to see the errors to fix.
If we wanted to keep the "one-line" aspect, something like
`identity = lambda x: x` becomes `def identity(x): return x` though I
think putting the return statement on a separate line is less awkward to
read. Other opinions welcome.
--
Ticket URL: <https://code.djangoproject.com/ticket/26125>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* Attachment "26125.diff" added.
Django
Reporter: timgraham | Owner:
Type: | andersonresende
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by andersonresende):
* owner: nobody => andersonresende
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/26125#comment:1>
Django
Reporter: timgraham | Owner: userimack
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by userimack):
* owner: andersonresende => userimack
--
Ticket URL: <https://code.djangoproject.com/ticket/26125#comment:2>
Django
Reporter: timgraham | Owner: userimack
Type: | Status: assigned
Cleanup/optimization |
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by timgraham):
@andersonresende, userimack is a new contributor who started this ticket
but forgot to assign it. Sorry for that.
--
Ticket URL: <https://code.djangoproject.com/ticket/26125#comment:3>
Django
Reporter: timgraham | Owner: userimack
Type: | Status: assigned
Cleanup/optimization |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/6028 PR] (not all errors are fixed
yet). Please uncheck "Patch needs improvement" when all errors are
resolved.
--
Ticket URL: <https://code.djangoproject.com/ticket/26125#comment:4>
Django
Reporter: timgraham | Owner: userimack
Type: | Status: assigned
Cleanup/optimization |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by userimack):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26125#comment:5>
Django
Reporter: timgraham | Owner: userimack
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"60586dd7379b295b72d8af4e03423c286913b5e8" 60586dd7]:
{{{
#!CommitTicketReference repository=""
revision="60586dd7379b295b72d8af4e03423c286913b5e8"
Fixed #26125 -- Fixed E731 flake warnings.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26125#comment:6>