[Django] #30013: Fix compatiblity with mysqlclient 1.3.14
Django
-------------------------------------+-------------------------------------
Reporter: Tim | Owner: Tim Graham
Graham |
Type: | Status: assigned
Cleanup/optimization |
Component: Database | Version: 2.1
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
mysqlclient 1.3.14 broke `DatabaseOperations.last_executed_query()` by
removing
[https://github.com/django/django/blob/fbc7e4138921d0fbee823ce6ea9774de66d27e47/django/db/backends/mysql/operations.py#L144
_last_executed] in [https://github.com/PyMySQL/mysqlclient-python/pull/283
PR #283].
--
Ticket URL: <https://code.djangoproject.com/ticket/30013>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Graham
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/10726 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/30013#comment:1>
Django
-------------------------------------+-------------------------------------
Type: | Graham
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
I added a commit to the PR to fix
`backends.mysql.test_schema.SchemaEditorTests.test_quote_value
(value=1.754)` following https://github.com/PyMySQL/mysqlclient-
python/commit/09018914e1f271afc1aee2c2f233a59032f9effc.
--
Ticket URL: <https://code.djangoproject.com/ticket/30013#comment:2>
Django
-------------------------------------+-------------------------------------
Type: | Graham
Component: Database layer | Version: 2.1
(models, ORM) |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"284b3221a2c17af5bfe2edbf851ac0a9901f91a0" 284b3221]:
{{{
#!CommitTicketReference repository=""
revision="284b3221a2c17af5bfe2edbf851ac0a9901f91a0"
Fixed #30013 -- Fixed DatabaseOperations.last_executed_query() with
mysqlclient 1.3.14+.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30013#comment:3>
Django
-------------------------------------+-------------------------------------
Type: | Graham
Cleanup/optimization | Status: closed
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"734ce71824180740f2318750ae2436f4b60c30b1" 734ce71]:
{{{
#!CommitTicketReference repository=""
revision="734ce71824180740f2318750ae2436f4b60c30b1"
Refs #30013 -- Fixed SchemaEditor.quote_value() test for mysqlclient
1.3.14+.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30013#comment:4>
Django
-------------------------------------+-------------------------------------
Type: | Graham
Cleanup/optimization | Status: closed
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"108490692701f74a09e4852d1ba98514a38f94ae" 10849069]:
{{{
#!CommitTicketReference repository=""
revision="108490692701f74a09e4852d1ba98514a38f94ae"
[2.1.x] Fixed #30013 -- Fixed DatabaseOperations.last_executed_query()
with mysqlclient 1.3.14+.
Backport of 284b3221a2c17af5bfe2edbf851ac0a9901f91a0 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30013#comment:5>
Django
-------------------------------------+-------------------------------------
Type: | Graham
Cleanup/optimization | Status: closed
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"389ef05b1b74dcebcaf5b6885a9ff00ceccdb737" 389ef05]:
{{{
#!CommitTicketReference repository=""
revision="389ef05b1b74dcebcaf5b6885a9ff00ceccdb737"
[2.1.x] Refs #30013 -- Fixed SchemaEditor.quote_value() test for
mysqlclient 1.3.14+.
Backport of 734ce71824180740f2318750ae2436f4b60c30b1 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30013#comment:6>
Django
-------------------------------------+-------------------------------------
Type: | Graham
Cleanup/optimization | Status: closed
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by GitHub <noreply@…>):
In [changeset:"13501d162f4b243f20e2a89e0799ceb796ea9756" 13501d1]:
{{{
#!CommitTicketReference repository=""
revision="13501d162f4b243f20e2a89e0799ceb796ea9756"
[2.0.x] Refs #30013 -- Doc'd that mysqlclient 1.3.14 and later isn't
supported.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30013#comment:7>
Django
-------------------------------------+-------------------------------------
Type: | Graham
Cleanup/optimization | Status: closed
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"2ea1e0e58d3e0afffda4308a45e6c96693f3a7c9" 2ea1e0e5]:
{{{
#!CommitTicketReference repository=""
revision="2ea1e0e58d3e0afffda4308a45e6c96693f3a7c9"
[1.11.x] Refs #30013 -- Doc'd that mysqlclient 1.3.14 and later isn't
supported.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30013#comment:8>
Django
-------------------------------------+-------------------------------------
Type: | Graham
Cleanup/optimization | Status: closed
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Ed Morley (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/30013#comment:9>