[Django] #25262: Consider dropping FlatPage.enable_comments

[Django]

#25262: Consider dropping FlatPage.enable_comments
------------------------------------------------+------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.flatpages | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
This field isn't documented or used anywhere but it appears in the admin
interface which is confusing.

Perhaps it was used by d.c.comments before we axed it?

--
Ticket URL: <https://code.djangoproject.com/ticket/25262>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#25262: Consider dropping FlatPage.enable_comments
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.flatpages | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------

Comment (by timgraham):

[https://groups.google.com/d/topic/django-
developers/XNe_BoomNyo/discussion django-developers discussion]

--
Ticket URL: <https://code.djangoproject.com/ticket/25262#comment:1>

[Django]

#25262: Better document FlatPage.enable_comments and remove it from default
ModelAdmin
--------------------------------------+------------------------------------

Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.flatpages | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Accepted
* easy: 0 => 1

Comment:

From the thread:
Me: A compromise could be to hide the field in the default ModelAdmin and
let those who want it to enable it with a custom ModelAdmin. What do you
think?
[[BR]]
Aymeric: That would resolve my problem of “WTF is this field” without
causing too much headache. We should also put a comment in the source code
stating that the field is unused but we don’t want to remove it because of
backwards-compatibility.

--
Ticket URL: <https://code.djangoproject.com/ticket/25262#comment:2>

[Django]

#25262: Better document FlatPage.enable_comments and remove it from default
ModelAdmin
--------------------------------------+------------------------------------

Reporter: aaugustin | Owner: Y3K
Type: Cleanup/optimization | Status: assigned
Component: contrib.flatpages | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by Y3K):

* owner: nobody => Y3K
* status: new => assigned

Comment:

I'll take this one, as my first Django ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/25262#comment:3>

[Django]

#25262: Better document FlatPage.enable_comments and remove it from default
ModelAdmin
--------------------------------------+------------------------------------
Reporter: aaugustin | Owner: Y3K
Type: Cleanup/optimization | Status: assigned

Component: contrib.flatpages | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Y3K):

* has_patch: 0 => 1

Comment:

Github pull request: https://github.com/django/django/pull/5204

* Removed the field `enable_comments` from the `FlatPageAdmin` class.
* Added the change to release notes for 1.9
* Added the change to FlatPage documentation

--
Ticket URL: <https://code.djangoproject.com/ticket/25262#comment:4>

[Django]

#25262: Better document FlatPage.enable_comments and remove it from default
ModelAdmin
--------------------------------------+------------------------------------
Reporter: aaugustin | Owner: Y3K

Type: Cleanup/optimization | Status: closed
Component: contrib.flatpages | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"b649f68649b0cba2de9e6bb8cf3d3fe468372c2e" b649f68]:
{{{
#!CommitTicketReference repository=""
revision="b649f68649b0cba2de9e6bb8cf3d3fe468372c2e"
Fixed #25262 -- Removed the enable_comments field from FlatPageAdmin.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25262#comment:5>