[Django] #25181: Move views.generic.dates.timezone_today() to utils.timezone
Django
---------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: New feature | Status: new
Component: Utilities | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+------------------------
Carl says, "That's the most straightforward implementation I know of. I
think it would make sense as `timezone.today()`. I've reimplemented it in
at least two projects. Also, the first time I implemented it I left out
the .localtime() and didn't catch the bug for quite a while. An argument
for adding it to Django."
--
Ticket URL: <https://code.djangoproject.com/ticket/25181>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timgraham | Owner: kswiat
Type: New feature | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by kswiat):
* owner: nobody => kswiat
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:1>
Django
Reporter: timgraham | Owner: kswiat
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by carljm):
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:2>
Django
Reporter: timgraham | Owner: kswiat
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by kswiat):
* needs_docs: 1 => 0
Comment:
I appended the `ref/utils`.
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:3>
Django
Reporter: timgraham | Owner: kswiat
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin
Comment:
Looks good, pending some minor comments.
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:4>
Django
Reporter: timgraham | Owner: kswiat
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
Discussion continues on the pull request.
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:5>
Django
Reporter: timgraham | Owner: kswiat
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by bmispelon):
Closed #27082 as a duplicated.
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:6>
Django
Reporter: timgraham | Owner: kswiat
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jdufresne):
* needs_better_patch: 1 => 0
Comment:
New [https://github.com/django/django/pull/7134 PR] based on kswiat's
original work. It incorporates the feedback from the previous reviews.
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:7>
Django
-----------------------------+---------------------------------------------
Reporter: timgraham | Owner: kswiat
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:8>
Django
-----------------------------+---------------------------------------------
Reporter: timgraham | Owner: kswiat
Component: Utilities | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"ff1e7b4eb43737bf2752197036663cee58922317" ff1e7b4e]:
{{{
#!CommitTicketReference repository=""
revision="ff1e7b4eb43737bf2752197036663cee58922317"
Fixed #25181 -- Added localdate() function to get date in a different time
zone.
Thanks Konrad Świat for the original patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:9>
Django
-----------------------------+---------------------------------------------
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"a7a36bb4d8ef7f03c2df9e3279c8f488ab3641d1" a7a36bb]:
{{{
#!CommitTicketReference repository=""
revision="a7a36bb4d8ef7f03c2df9e3279c8f488ab3641d1"
Refs #25181 -- Updated timezone.now() docs about obtaining the time in the
current time zone.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:10>
Django
-----------------------------+---------------------------------------------
Reporter: Tim Graham | Owner: Konrad Świat
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"2679cdbea2901ea83fdc9562a92d3760af39ae53" 2679cdbe]:
{{{
#!CommitTicketReference repository=""
revision="2679cdbea2901ea83fdc9562a92d3760af39ae53"
[2.0.x] Refs #25181 -- Updated timezone.now() docs about obtaining the
time in the current time zone.
Backport of a7a36bb4d8ef7f03c2df9e3279c8f488ab3641d1 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25181#comment:11>