[Django] #26750: Add new Field type for postgis POINTZ

13 views
Skip to first unread message

Django

unread,
Jun 13, 2016, 9:53:15 AM6/13/16
to django-...@googlegroups.com
#26750: Add new Field type for postgis POINTZ
-------------------------------+-----------------------------------
Reporter: saintbyte | Owner: nobody
Type: Uncategorized | Status: new
Component: GIS | Version: 1.9
Severity: Normal | Keywords: inspectdb,gis,postgis
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------
I create on RoR , models with type "t.geography "location",
limit: {:srid=>4326, :type=>"point", :has_z=>true, :geographic=>true}".
And try make inspectdb in my django project , but ./manage.py inspectdb
fails. It database its seem like "location geography(PointZ,4326)" .

--
Ticket URL: <https://code.djangoproject.com/ticket/26750>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 13, 2016, 10:10:24 AM6/13/16
to django-...@googlegroups.com
#26750: Add new Field type for postgis POINTZ
-------------------------------------+-------------------------------------

Reporter: saintbyte | Owner: nobody
Type: Uncategorized | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by charettes):

* needs_docs: => 0
* needs_better_patch: => 1
* version: 1.9 => master
* needs_tests: => 1
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:1>

Django

unread,
Jun 17, 2016, 10:32:59 AM6/17/16
to django-...@googlegroups.com
#26750: Add new Field type for postgis POINTZ
-------------------------------------+-------------------------------------

Reporter: saintbyte | Owner: nobody
Type: Uncategorized | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by timgraham):

Do we need a separate field or can this be `PointField(dim=3)` as
described in #26775?

--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:2>

Django

unread,
Jun 17, 2016, 11:27:29 AM6/17/16
to django-...@googlegroups.com
#26750: Add new Field type for postgis POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody
Type: New feature | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: duplicate

Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* status: new => closed
* type: Uncategorized => New feature
* resolution: => duplicate


--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:3>

Django

unread,
Jun 18, 2016, 12:02:00 PM6/18/16
to django-...@googlegroups.com
#26750: Add new Field type for postgis POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by claudep):

* status: closed => new
* resolution: duplicate =>


Comment:

Re-opening because introspection is a separate issue than field creation.

--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:4>

Django

unread,
Jun 18, 2016, 12:04:29 PM6/18/16
to django-...@googlegroups.com
#26750: Add introspection support for PostGIS POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody

Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 1 => 0
* has_patch: 1 => 0
* needs_tests: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:5>

Django

unread,
Jun 18, 2016, 12:16:08 PM6/18/16
to django-...@googlegroups.com
#26750: Add new Field type for postgis POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody

Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by claudep):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* needs_tests: 0 => 1


Comment:

This depends on resolution of #26775.

--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:6>

Django

unread,
Jun 18, 2016, 12:42:37 PM6/18/16
to django-...@googlegroups.com
#26750: Add introspection support for PostGIS POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody

Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 1 => 0

* needs_tests: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:7>

Django

unread,
Jun 18, 2016, 3:54:12 PM6/18/16
to django-...@googlegroups.com
#26750: Add introspection support for PostGIS POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody

Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by claudep):

[https://github.com/django/django/pull/6801 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:8>

Django

unread,
Jun 18, 2016, 7:35:26 PM6/18/16
to django-...@googlegroups.com
#26750: Add introspection support for PostGIS POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody

Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


Comment:

New test isn't passing on PostGIS.

--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:9>

Django

unread,
Jun 19, 2016, 1:09:07 PM6/19/16
to django-...@googlegroups.com
#26750: Add introspection support for PostGIS POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody

Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
inspectdb,gis,postgis |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by claudep):

* needs_better_patch: 1 => 0


Comment:

The test didn't pass on Spatialite, should be fixed now.

--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:10>

Django

unread,
Jun 20, 2016, 6:51:33 AM6/20/16
to django-...@googlegroups.com
#26750: Add introspection support for PostGIS POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody

Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
inspectdb,gis,postgis | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:11>

Django

unread,
Jun 21, 2016, 9:23:28 AM6/21/16
to django-...@googlegroups.com
#26750: Add introspection support for PostGIS POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody
Type: New feature | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
inspectdb,gis,postgis | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed

* resolution: => fixed


Comment:

In [changeset:"140c23502651dde4a562f3d732c862b5ccca2294" 140c2350]:
{{{
#!CommitTicketReference repository=""
revision="140c23502651dde4a562f3d732c862b5ccca2294"
Fixed #26750 -- Fixed introspection for geography point field with dim=3

Thanks Yegor Kazantsev for the report and the initial patch.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:12>

Django

unread,
Jun 21, 2016, 9:24:41 AM6/21/16
to django-...@googlegroups.com
#26750: Add introspection support for PostGIS POINTZ
-------------------------------------+-------------------------------------
Reporter: saintbyte | Owner: nobody

Type: New feature | Status: closed
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
inspectdb,gis,postgis | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"b1592dd73b47d81e8a8f5e585827fccde015c7c2" b1592dd7]:
{{{
#!CommitTicketReference repository=""
revision="b1592dd73b47d81e8a8f5e585827fccde015c7c2"
[1.10.x] Fixed #26750 -- Fixed introspection for geography point field
with dim=3

Thanks Yegor Kazantsev for the report and the initial patch.

Backport of 140c23502 from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26750#comment:13>

Reply all
Reply to author
Forward
0 new messages