[Django] #28227: Custom Range documentation refers to non-importable class

15 views
Skip to first unread message

Django

unread,
May 20, 2017, 9:16:03 AM5/20/17
to django-...@googlegroups.com
#28227: Custom Range documentation refers to non-importable class
---------------------------------------------+------------------------
Reporter: Matthew Schinckel | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
https://docs.djangoproject.com/en/1.10/ref/contrib/postgres/fields
/#defining-your-own-range-types

BaseRangeField is not available in "django.contrib.postgres.forms", only
"django.contrib.postgres.forms.ranges".

--
Ticket URL: <https://code.djangoproject.com/ticket/28227>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 20, 2017, 9:16:34 AM5/20/17
to django-...@googlegroups.com
#28227: Custom Range documentation refers to non-importable class
-----------------------------------+--------------------------------------

Reporter: Matthew Schinckel | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.postgres | Version: 1.11
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by Matthew Schinckel):

* component: Uncategorized => contrib.postgres


--
Ticket URL: <https://code.djangoproject.com/ticket/28227#comment:1>

Django

unread,
May 20, 2017, 9:26:20 AM5/20/17
to django-...@googlegroups.com
#28227: Custom Range documentation refers to non-importable class
-----------------------------------+------------------------------------

Reporter: Matthew Schinckel | Owner: nobody
Type: Bug | Status: new

Component: contrib.postgres | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Claude Paroz):

* type: Uncategorized => Bug
* easy: 0 => 1
* stage: Unreviewed => Accepted


Comment:

I think that both `BaseRangeField` and `RangeWidget` should be included in
the `__all__` list. I suspect their absence in that list was an oversight
when those classes have been added.

--
Ticket URL: <https://code.djangoproject.com/ticket/28227#comment:2>

Django

unread,
May 20, 2017, 5:09:16 PM5/20/17
to django-...@googlegroups.com
#28227: Custom Range documentation refers to non-importable class
-----------------------------------+------------------------------------

Reporter: Matthew Schinckel | Owner: nobody
Type: Bug | Status: new
Component: contrib.postgres | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Tom):

* has_patch: 0 => 1


Comment:

I made a patch here: https://github.com/django/django/pull/8526

I hope this is sufficient?

--
Ticket URL: <https://code.djangoproject.com/ticket/28227#comment:3>

Django

unread,
May 20, 2017, 9:46:56 PM5/20/17
to django-...@googlegroups.com
#28227: Custom Range documentation refers to non-importable class
-----------------------------------+------------------------------------

Reporter: Matthew Schinckel | Owner: nobody
Type: Bug | Status: closed
Component: contrib.postgres | Version: 1.11
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"e9c7f118a7ab19a5441f2dceeb1765138d44daf7" e9c7f118]:
{{{
#!CommitTicketReference repository=""
revision="e9c7f118a7ab19a5441f2dceeb1765138d44daf7"
Fixed #28227 -- Allowed importing BaseRangeField/RangeWidget from
contrib.postgres.forms.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28227#comment:4>

Django

unread,
May 20, 2017, 9:48:02 PM5/20/17
to django-...@googlegroups.com
#28227: Make BaseRangeField importable at django.contrib.postgres.forms as
documented
-----------------------------------+------------------------------------

Reporter: Matthew Schinckel | Owner: nobody
Type: Bug | Status: closed
Component: contrib.postgres | Version: 1.11
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------+------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/28227#comment:5>

Reply all
Reply to author
Forward
0 new messages