[Django] #25335: QuerySet.iterator doesn't return an iterator any more
Django
----------------------------------------------+--------------------
Reporter: gavinwahl | Owner: nobody
Type: Bug | Status: new
Component: Database layer (models, ORM) | Version: master
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+--------------------
In django 1.8, QuerySet.iterator returns an iterator. In master, it
returns an iterable. This is a regression introduced by 4c3bfe90 (#24211).
The ModelIterator, ValuesListIterator, etc that that commit added are not
actually iterators, they are iterables.
--
Ticket URL: <https://code.djangoproject.com/ticket/25335>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: gavinwahl | Owner: nobody
Type: Bug | Status: new
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by gavinwahl):
* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_docs: => 0
Comment:
https://github.com/django/django/pull/5222
--
Ticket URL: <https://code.djangoproject.com/ticket/25335#comment:1>
Django
Reporter: gavinwahl | Owner: nobody
Type: Bug | Status: new
(models, ORM) |
Severity: Release blocker | Resolution:
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/25335#comment:2>
Django
Reporter: gavinwahl | Owner: nobody
Type: Bug | Status: new
(models, ORM) |
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* cc: loic (added)
* stage: Accepted => Ready for checkin
Comment:
Loic, can you double check?
--
Ticket URL: <https://code.djangoproject.com/ticket/25335#comment:3>
Django
Reporter: gavinwahl | Owner: nobody
Type: Bug | Status: new
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by loic):
Looks good, +1.
--
Ticket URL: <https://code.djangoproject.com/ticket/25335#comment:4>
Django
Reporter: gavinwahl | Owner: nobody
Type: Bug | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"627c7eb7bf81fe4faac552475fa13f449dc8dd33" 627c7eb7]:
{{{
#!CommitTicketReference repository=""
revision="627c7eb7bf81fe4faac552475fa13f449dc8dd33"
Fixed #25335 -- Fixed regression where QuerySet.iterator() didn't return
an iterator.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25335#comment:5>