Re: [Django] #8033: Better error handling for gettext and gettext_lazy issues
Django
--------------------------------------+------------------------------------
Reporter: msaelices | Owner:
Type: Cleanup/optimization | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by claudep):
* needs_better_patch: 1 => 0
* type: New feature => Cleanup/optimization
Comment:
I think that after app loading refactor, the situation has improved a lot.
However, here is a patch to add a complementary error message to this sort
of errors: https://github.com/django/django/pull/2838
--
Ticket URL: <https://code.djangoproject.com/ticket/8033#comment:23>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: msaelices | Owner:
Type: | Status: new
Cleanup/optimization | Version: master
Component: | Resolution:
Internationalization | Triage Stage: Ready for
Severity: Normal | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/8033#comment:24>
Django
Reporter: msaelices | Owner:
Type: Cleanup/optimization | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* stage: Ready for checkin => Accepted
Comment:
If we're creating a specific exception for the app registry not being
ready, it has no reason to inherit RuntimeError.
Furthermore, this patch changes the error message without updating the
docs — which are important as this is going to be one of the pain points
in 1.7.
--
Ticket URL: <https://code.djangoproject.com/ticket/8033#comment:25>
Django
--------------------------------------+------------------------------------
Reporter: msaelices | Owner:
Type: Cleanup/optimization | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by aaugustin):
Upon further thought, I'm in favor of introducing an `AppRegistryNotReady`
exception and updating the documentation accordingly.
--
Ticket URL: <https://code.djangoproject.com/ticket/8033#comment:26>
Django
--------------------------------------+------------------------------------
Reporter: msaelices | Owner:
Type: Cleanup/optimization | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by claudep):
Pull request updated.
--
Ticket URL: <https://code.djangoproject.com/ticket/8033#comment:27>
Django
Reporter: msaelices | Owner:
Type: | Status: new
Cleanup/optimization | Version: master
Component: | Resolution:
Internationalization | Triage Stage: Ready for
Severity: Normal | checkin
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/8033#comment:28>
Django
-------------------------------------+-------------------------------------
Type: | Paroz <claude@…>
Cleanup/optimization | Status: closed
Component: | Version: master
Internationalization | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz <claude@…>):
* status: new => closed
* owner: => Claude Paroz <claude@…>
* resolution: => fixed
Comment:
In [changeset:"9618d68b345fe69c787f8426b07e920e647e05f3"]:
{{{
#!CommitTicketReference repository=""
revision="9618d68b345fe69c787f8426b07e920e647e05f3"
Fixed #8033 -- Explained app registry error during translation setup
Thanks Tim Graham and Aymeric Augustin for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/8033#comment:29>
Django
-------------------------------------+-------------------------------------
Reporter: msaelices | Owner: Claude
Type: | Paroz <claude@…>
Cleanup/optimization | Status: closed
Component: | Version: master
Internationalization | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz <claude@…>):
In [changeset:"f50a17785cdb67bc9d1b146d01c731cb6bfc48cf"]:
{{{
#!CommitTicketReference repository=""
revision="f50a17785cdb67bc9d1b146d01c731cb6bfc48cf"
[1.7.x] Fixed #8033 -- Explained app registry error during translation
setup
Thanks Tim Graham and Aymeric Augustin for the review.
Backport of 9618d68b34 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/8033#comment:30>