[Django] #24333: admin history view can fail with non-integer slug

[Django]

#24333: admin history view can fail with non-integer slug
-----------------------------------------+---------------------------
Reporter: timgraham | Owner: timgraham
Type: Bug | Status: new
Component: contrib.admin | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+---------------------------
A URL like `/admin/app/model/bad/history/` will raise `ValueError` if
model's pk is an integer.

--
Ticket URL: <https://code.djangoproject.com/ticket/24333>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#24333: admin history view can fail with non-integer slug

-------------------------------+-------------------------------------

Reporter: timgraham | Owner: timgraham
Type: Bug | Status: new
Component: contrib.admin | Version: 1.7

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------+-------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/4119 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/24333#comment:1>

[Django]

#24333: admin history view can fail with non-integer slug

-------------------------------------+-------------------------------------

Reporter: timgraham | Owner: timgraham
Type: Bug | Status: new
Component: contrib.admin | Version: 1.7

Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by charettes):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/24333#comment:2>

[Django]

#24333: admin history view can fail with non-integer slug

-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"d64baaef3b95abe9ae5d07317c9bf4df02cb8592"]:
{{{
#!CommitTicketReference repository=""
revision="d64baaef3b95abe9ae5d07317c9bf4df02cb8592"
Fixed #24333 -- Fixed admin history view crash with non-integer slug.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24333#comment:3>

[Django]

#24333: admin history view can fail with non-integer slug

-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.7

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"03f4e2d90997aec4c8f57c5c9b7925d70194327e"]:
{{{
#!CommitTicketReference repository=""
revision="03f4e2d90997aec4c8f57c5c9b7925d70194327e"
[1.8.x] Fixed #24333 -- Fixed admin history view crash with non-integer
slug.

Backport of d64baaef3b95abe9ae5d07317c9bf4df02cb8592 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24333#comment:4>