[Django] #25300: Add a test for BoundField.id_for_label

4 views
Skip to first unread message

Django

unread,
Aug 21, 2015, 11:58:30 AM8/21/15
to django-...@googlegroups.com
#25300: Add a test for BoundField.id_for_label
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
[https://github.com/django/django/blob/d3bc86ec11bb22f06b5e30fac891ef3e43f82a6d/django/forms/forms.py#L702-L711
Removing it] won't result in any test failures, but it's a documented
method. A test or two should be added in `tests/forms_tests`.

--
Ticket URL: <https://code.djangoproject.com/ticket/25300>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 21, 2015, 12:20:43 PM8/21/15
to django-...@googlegroups.com
#25300: Add a test for BoundField.id_for_label
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: mlorant
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by mlorant):

* owner: nobody => mlorant
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/25300#comment:1>

Django

unread,
Aug 21, 2015, 12:52:02 PM8/21/15
to django-...@googlegroups.com
#25300: Add a test for BoundField.id_for_label
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: mlorant
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by mlorant):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25300#comment:2>

Django

unread,
Aug 22, 2015, 10:13:36 AM8/22/15
to django-...@googlegroups.com
#25300: Add a test for BoundField.id_for_label
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: mlorant
Type: Cleanup/optimization | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"7d60659e22c869149cc17f2568a8e073412ea219" 7d60659]:
{{{
#!CommitTicketReference repository=""
revision="7d60659e22c869149cc17f2568a8e073412ea219"
Fixed #25300 -- Added unit tests for BoundField.id_for_label
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25300#comment:3>

Django

unread,
Sep 9, 2015, 9:30:50 AM9/9/15
to django-...@googlegroups.com
#25300: Add a test for BoundField.id_for_label
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: mlorant
Type: Cleanup/optimization | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"dae81c6ec62a76c1f28745ae3642c2d4a37ce259" dae81c6e]:
{{{
#!CommitTicketReference repository=""
revision="dae81c6ec62a76c1f28745ae3642c2d4a37ce259"
Refs #25300 -- Fixed reference to TextInput in a test.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25300#comment:4>

Reply all
Reply to author
Forward
0 new messages