[Django] #27100: The pre-migration state used to generate the `AppConfig` exposed through the `pre_migrate` signal should include already applied migration changes

6 views
Skip to first unread message

Django

unread,
Aug 20, 2016, 5:05:00 PM8/20/16
to django-...@googlegroups.com
#27100: The pre-migration state used to generate the `AppConfig` exposed through
the `pre_migrate` signal should include already applied migration changes
-------------------------------------------+---------------------------
Reporter: charettes | Owner: charettes
Type: Bug | Status: new
Component: Migrations | Version: 1.10
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+---------------------------
It was overlooked in the original design because of the way the test suite
deals with migration and prevent #24067 from working under normal
circumstances.

The biggest challenge will be to avoid double working as many parts are
performance critical.

--
Ticket URL: <https://code.djangoproject.com/ticket/27100>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 20, 2016, 5:05:21 PM8/20/16
to django-...@googlegroups.com
#27100: The pre-migration state used to generate the `AppConfig` exposed through
the `pre_migrate` signal should include already applied migration changes
---------------------------------+-------------------------------------
Reporter: charettes | Owner: charettes
Type: Bug | Status: assigned
Component: Migrations | Version: 1.10
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-------------------------------------
Changes (by charettes):

* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/27100#comment:1>

Django

unread,
Aug 20, 2016, 6:20:50 PM8/20/16
to django-...@googlegroups.com
#27100: The pre-migration state used to generate the `AppConfig` exposed through
the `pre_migrate` signal should include already applied migration changes
---------------------------------+-------------------------------------
Reporter: charettes | Owner: charettes
Type: Bug | Status: assigned
Component: Migrations | Version: 1.10
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-------------------------------------
Changes (by charettes):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/7133 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27100#comment:2>

Django

unread,
Aug 22, 2016, 6:54:34 PM8/22/16
to django-...@googlegroups.com
#27100: The pre-migration state used to generate the `AppConfig` exposed through
the `pre_migrate` signal should include already applied migration changes
-------------------------------------+-------------------------------------
Reporter: charettes | Owner: charettes
Type: Bug | Status: assigned
Component: Migrations | Version: 1.10
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27100#comment:3>

Django

unread,
Aug 24, 2016, 1:36:30 AM8/24/16
to django-...@googlegroups.com
#27100: The pre-migration state used to generate the `AppConfig` exposed through
the `pre_migrate` signal should include already applied migration changes
-------------------------------------+-------------------------------------
Reporter: charettes | Owner: charettes
Type: Bug | Status: closed
Component: Migrations | Version: 1.10
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette <charette.s@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"d5c4ea524679a787fe11c927448e44e95646096b" d5c4ea52]:
{{{
#!CommitTicketReference repository=""
revision="d5c4ea524679a787fe11c927448e44e95646096b"
Fixed #27100 -- Included already applied migration changes in the pre-
migrate state.

Refs #24100.

Thanks Tim for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27100#comment:4>

Django

unread,
Aug 24, 2016, 1:39:05 AM8/24/16
to django-...@googlegroups.com
#27100: The pre-migration state used to generate the `AppConfig` exposed through
the `pre_migrate` signal should include already applied migration changes
-------------------------------------+-------------------------------------
Reporter: charettes | Owner: charettes
Type: Bug | Status: closed
Component: Migrations | Version: 1.10

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Simon Charette <charette.s@…>):

In [changeset:"0b454804db5729eedbb117c90de4a3ad5fb397ee" 0b45480]:
{{{
#!CommitTicketReference repository=""
revision="0b454804db5729eedbb117c90de4a3ad5fb397ee"
[1.10.x] Fixed #27100 -- Included already applied migration changes in the
pre-migrate state.

Refs #24100.

Thanks Tim for the review.

Backport of d5c4ea524679a787fe11c927448e44e95646096b from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27100#comment:5>

Reply all
Reply to author
Forward
0 new messages