[Django] #27204: Clashing m2m intermediate table validation should ignore unmanaged models
Django
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
Component: Core (System checks) | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 1
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The check added in #12810 currently triggers on some unmanaged models in
Django's test suite that intentionally use clashing names. I think the
correct solution is to ignore unmanaged models.
ERRORS:
model_options.Article.authors: (fields.E340) The field's intermediary
table 'model_options_articleref_authors' clashes with the table name of
'model_options.ArticleRef.authors'.
model_options.Article.reviewers: (fields.E340) The field's intermediary
table 'model_options_articleref_reviewers' clashes with the table name of
'model_options.ArticleRef.reviewers'.
model_options.ArticleRef.authors: (fields.E340) The field's intermediary
table 'model_options_articleref_authors' clashes with the table name of
'model_options.Article.authors'.
model_options.ArticleRef.reviewers: (fields.E340) The field's intermediary
table 'model_options_articleref_reviewers' clashes with the table name of
'model_options.Article.reviewers'.
unmanaged_models.C01.mm_a: (fields.E340) The field's intermediary table
'd01' clashes with the table name of 'unmanaged_models.Intermediate'.
unmanaged_models.C02.mm_a: (fields.E340) The field's intermediary table
'd01' clashes with the table name of 'unmanaged_models.C01.mm_a'.
--
Ticket URL: <https://code.djangoproject.com/ticket/27204>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
Component: Core (System checks) | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* Attachment "27204.diff" added.
patch without tests
Django
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
Component: Core (System checks) | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_tests: 1 => 0
Comment:
[https://github.com/django/django/pull/7224 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/27204#comment:1>
Django
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
checks) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by berkerpeksag):
* stage: Accepted => Ready for checkin
Comment:
[https://github.com/django/django/pull/7224/ PR #7224] looks good to me
and tests passed on my system. Just left a comment about a potential typo
on GitHub.
--
Ticket URL: <https://code.djangoproject.com/ticket/27204#comment:2>
Django
Reporter: timgraham | Owner: nobody
Type: Bug | Status: closed
Component: Core (System | Version: 1.10
checks) |
Keywords: | Triage Stage: Ready for
| checkin
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"e7abb5ba8608f90ce97c6edb031ae877195616f5" e7abb5ba]:
{{{
#!CommitTicketReference repository=""
revision="e7abb5ba8608f90ce97c6edb031ae877195616f5"
Fixed #27204 -- Made clashing m2m intermediary table checks ignore
unmanaged models.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27204#comment:3>