Re: [Django] #15888: Inspect `settings.CACHES` in order to make`createcachetable` automatic

[Django]

#15888: Inspect `settings.CACHES` in order to make`createcachetable` automatic
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin
Type: | Status: new
Cleanup/optimization | Component: Core (Cache system)
Milestone: | Severity: Normal
Version: 1.3 | Keywords:
Resolution: | Has patch: 0
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by jezdez):

* ui_ux: => 0

Comment:

FYI, #15255 was committed.

--
Ticket URL: <https://code.djangoproject.com/ticket/15888#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#15888: Inspect `settings.CACHES` in order to make`createcachetable` automatic

--------------------------------------+------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Cache system) | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by aaugustin):

* owner: aaugustin => nobody

--
Ticket URL: <https://code.djangoproject.com/ticket/15888#comment:4>

[Django]

#15888: Inspect `settings.CACHES` in order to make`createcachetable` automatic
--------------------------------------+------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Cache system) | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by claudep):

I've just attached an initial implementation. Tests should probably be
still completed.
The question is now: do we want to keep the legacy behaviour of specifying
one or more table names as arguments, or do we want to deprecate this?

--
Ticket URL: <https://code.djangoproject.com/ticket/15888#comment:5>

[Django]

#15888: Inspect `settings.CACHES` in order to make`createcachetable` automatic
--------------------------------------+------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new

Component: Core (Cache system) | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by claudep):

* has_patch: 0 => 1
* version: 1.3 => master

Comment:

Patch updated to current trunk and PR created:
https://github.com/django/django/pull/1727

--
Ticket URL: <https://code.djangoproject.com/ticket/15888#comment:6>

[Django]

#15888: Inspect `settings.CACHES` in order to make`createcachetable` automatic
--------------------------------------+------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Cache system) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by aaugustin):

* needs_better_patch: 0 => 1

Comment:

Tim suggested some improvements on the pull request.

--
Ticket URL: <https://code.djangoproject.com/ticket/15888#comment:7>

[Django]

#15888: Inspect `settings.CACHES` in order to make`createcachetable` automatic

-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Core (Cache system) | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by timo):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/15888#comment:8>

[Django]

#15888: Inspect `settings.CACHES` in order to make`createcachetable` automatic
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody

Type: | Status: closed
Cleanup/optimization | Version: master
Component: Core (Cache system) | Resolution: fixed

Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"1e8eadc94e3b27fe90ce9356b48e8543a1ff590e"]:
{{{
#!CommitTicketReference repository=""
revision="1e8eadc94e3b27fe90ce9356b48e8543a1ff590e"
Fixed #15888 -- Made tablename argument of createcachetable optional

Thanks Aymeric Augustin for the report and the documentation and
Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/15888#comment:9>