[Django] #24116: Refactor AdminSite.check_dependencies with the checks framework
Django
------------------------------------------------+------------------------
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The title says it all.
--
Ticket URL: <https://code.djangoproject.com/ticket/24116>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: aaugustin | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by aaugustin:
Old description:
> The title says it all.
New description:
The title says it all.
This ticket should also consider improving or dropping the check for the
`auth` context processor. Currently it's skipped when there isn't exactly
one Django templates engine configured in `TEMPLATES`. This could be
improved. It doesn't account for the possibility that a developer will
provide their own customized version. This is intractable.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:1>
Django
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:2>
Django
Reporter: aaugustin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by timgraham):
* easy: 0 => 1
Comment:
Another problem from duplicate ticket #25877, "It runs as a side effect of
loading the admin URLs. If it must run when Django starts it should be
called from `AdminAppConfig.ready()` instead."
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:3>
Django
Reporter: aaugustin | Owner:
Type: | vincepandolfo
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by vincepandolfo):
* owner: nobody => vincepandolfo
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:4>
Django
Reporter: aaugustin | Owner:
Type: | vincepandolfo
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by vincepandolfo):
I was reading the docs for the admin site and it lists some dependencies
that are not checked by the check_dependencies() method. Should I add
checks for those other dependencies or are the docs outdated?
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:5>
Django
Reporter: aaugustin | Owner:
Type: | vincepandolfo
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_docs: 0 => 1
* has_patch: 0 => 1
* needs_tests: 0 => 1
Comment:
Ideally we could also add some tests for this and documentation in
`docs/ref/checks.txt`.
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:6>
Django
Reporter: aaugustin | Owner:
Type: | vincepandolfo
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by vincepandolfo):
New commit diff:
[https://github.com/vincepandolfo/django/commit/99ac598e903c18dadca8dcc55a5d28aa6c95b47c]
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:7>
Django
Reporter: aaugustin | Owner:
Type: | vincepandolfo
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):
* needs_docs: 1 => 0
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:8>
Django
Reporter: aaugustin | Owner:
Type: | vincepandolfo
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
Left a round of review comments. Please uncheck "Patch needs improvement"
after it's updated.
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:9>
Django
Reporter: aaugustin | Owner:
Type: | vincepandolfo
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:10>
Django
Reporter: aaugustin | Owner:
Type: | vincepandolfo
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"0490d72f2a309ee2c6d73cdc5aa5cc381e14ae98" 0490d72]:
{{{
#!CommitTicketReference repository=""
revision="0490d72f2a309ee2c6d73cdc5aa5cc381e14ae98"
Fixed #24116 -- Moved AdminSite.check_dependencies() to system checks.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24116#comment:11>