[Django] #26002: Improve ModelAdmin.get_search_results() example

11 views
Skip to first unread message

Django

unread,
Dec 29, 2015, 8:49:34 AM12/29/15
to django-...@googlegroups.com
#26002: Improve ModelAdmin.get_search_results() example
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
There are two main issues:
* Clarify why the current example is the way it is instead of simply
listing 'age' in `search_fields`.
* Add other use cases like plugging in Solr or Haystack results, or
defining some custom search operators (+, -, *, @, ...)

[https://github.com/django/django/pull/5883 discussion on a pull request].

--
Ticket URL: <https://code.djangoproject.com/ticket/26002>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 3, 2016, 5:00:19 AM4/3/16
to django-...@googlegroups.com
#26002: Improve ModelAdmin.get_search_results() example
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: bbenko
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.9
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by bbenko):

* status: new => assigned
* owner: nobody => bbenko


--
Ticket URL: <https://code.djangoproject.com/ticket/26002#comment:1>

Django

unread,
Apr 4, 2016, 7:28:12 PM4/4/16
to django-...@googlegroups.com
#26002: Improve ModelAdmin.get_search_results() example
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: bbenko
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/6392 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/26002#comment:2>

Django

unread,
Jun 28, 2016, 2:17:20 PM6/28/16
to django-...@googlegroups.com
#26002: Improve ModelAdmin.get_search_results() example
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: bbenko
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by timgraham):

[https://github.com/django/django/pull/6844 Simpler PR] to explain the
current example.

--
Ticket URL: <https://code.djangoproject.com/ticket/26002#comment:3>

Django

unread,
Jun 30, 2016, 8:48:05 AM6/30/16
to django-...@googlegroups.com
#26002: Improve ModelAdmin.get_search_results() example
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: bbenko
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by berkerpeksag):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/26002#comment:4>

Django

unread,
Jun 30, 2016, 9:00:29 AM6/30/16
to django-...@googlegroups.com
#26002: Improve ModelAdmin.get_search_results() example
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: bbenko
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.9
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"c9d0a0f7f47c8496a9d8b0cfda94e2ef118d9ab3" c9d0a0f7]:
{{{
#!CommitTicketReference repository=""
revision="c9d0a0f7f47c8496a9d8b0cfda94e2ef118d9ab3"
Fixed #26002 -- Explained ModelAdmin.get_search_results() example.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26002#comment:5>

Django

unread,
Jun 30, 2016, 9:00:50 AM6/30/16
to django-...@googlegroups.com
#26002: Improve ModelAdmin.get_search_results() example
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: bbenko
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.9

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"96870045385fa0b7c3efeeaa4a2353c7334ee26b" 96870045]:
{{{
#!CommitTicketReference repository=""
revision="96870045385fa0b7c3efeeaa4a2353c7334ee26b"
[1.10.x] Fixed #26002 -- Explained ModelAdmin.get_search_results()
example.

Backport of c9d0a0f7f47c8496a9d8b0cfda94e2ef118d9ab3 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26002#comment:6>

Django

unread,
Jun 30, 2016, 9:01:00 AM6/30/16
to django-...@googlegroups.com
#26002: Improve ModelAdmin.get_search_results() example
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: bbenko
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.9

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"fe663b3d38fe59a8d922792b11ca05eba1afa575" fe663b3d]:
{{{
#!CommitTicketReference repository=""
revision="fe663b3d38fe59a8d922792b11ca05eba1afa575"
[1.9.x] Fixed #26002 -- Explained ModelAdmin.get_search_results() example.

Backport of c9d0a0f7f47c8496a9d8b0cfda94e2ef118d9ab3 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26002#comment:7>

Reply all
Reply to author
Forward
0 new messages