[Django] #21610: Broken link on "Community" page

4 views
Skip to first unread message

Django

unread,
Dec 13, 2013, 11:47:40 AM12/13/13
to django-...@googlegroups.com
#21610: Broken link on "Community" page
-----------------------------------------------+------------------------
Reporter: bmispelon | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-----------------------------------------------+------------------------
On the side bar of the "Community" page [1], the link explaining how to
sign up to our mailing lists without a Google account is broken.

The offending line is on line 31 of `templates/community_base.html` [2]


[1] https://www.djangoproject.com/community/
[2]
https://github.com/django/djangoproject.com/blob/master/templates/base_community.html#L31

--
Ticket URL: <https://code.djangoproject.com/ticket/21610>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 14, 2013, 5:27:43 PM12/14/13
to django-...@googlegroups.com
#21610: Broken link on "Community" page
-------------------------------------+------------------------------------

Reporter: bmispelon | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+------------------------------------

Comment (by claudep):

I would suggest to link `django-users` to
https://docs.djangoproject.com/en/dev/internals/mailing-lists/#django-
users (or backport the page to 1.6 and link to /stable/), remove the
subscribing form on the community page (and the FAQ link also). The same
for django-developers.

--
Ticket URL: <https://code.djangoproject.com/ticket/21610#comment:1>

Django

unread,
Dec 16, 2013, 8:46:03 AM12/16/13
to django-...@googlegroups.com
#21610: Broken link on "Community" page
-------------------------------------+------------------------------------

Reporter: bmispelon | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+------------------------------------
Changes (by anubhav9042):

* cc: anubhav9042 (added)


Comment:

I think we should just remove the form fields from sidebar and just give
the link to the page ​https://docs.djangoproject.com/en/dev/internals
/mailing-lists/#django-users for django-users and
https://docs.djangoproject.com/en/dev/internals/mailing-lists/#django-
developers for django-developers. That would be the best way as it would
require minimal changes and is also suitable.

--
Ticket URL: <https://code.djangoproject.com/ticket/21610#comment:2>

Django

unread,
Dec 17, 2013, 3:54:01 AM12/17/13
to django-...@googlegroups.com
#21610: Broken link on "Community" page
-------------------------------------+------------------------------------
Reporter: bmispelon | Owner: kevin_e
Type: Bug | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+------------------------------------
Changes (by kevin_e):

* owner: nobody => kevin_e
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/21610#comment:3>

Django

unread,
Dec 19, 2013, 8:52:06 AM12/19/13
to django-...@googlegroups.com
#21610: Broken link on "Community" page
-------------------------------------+------------------------------------
Reporter: bmispelon | Owner: kevin_e
Type: Bug | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+------------------------------------
Changes (by bmispelon):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1


Comment:

There's a PR here: https://github.com/django/djangoproject.com/pull/67

Note to kevin_e: make sure you post a comment on trac when you create a
pull request next time since not all of us subscribe to github alerts (I
found your pull request by accident)

I left a comment on it but other than that I think it looks good.

Once that small issue is fixed, you can remove the `patch needs
improvement` flag is set the ticket to `ready for checkin`.

Thanks

--
Ticket URL: <https://code.djangoproject.com/ticket/21610#comment:4>

Django

unread,
Dec 19, 2013, 10:21:33 AM12/19/13
to django-...@googlegroups.com
#21610: Broken link on "Community" page
-------------------------------------+------------------------------------
Reporter: bmispelon | Owner: kevin_e
Type: Bug | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+------------------------------------

Comment (by anubhav9042):

''kevin_e''
Please see the comments on your pull request.
Change '''/dev/''' to '''/1.6/''' in the links to the mailing lists.

--
Ticket URL: <https://code.djangoproject.com/ticket/21610#comment:5>

Django

unread,
Dec 19, 2013, 10:29:40 AM12/19/13
to django-...@googlegroups.com
#21610: Broken link on "Community" page
-------------------------------------+------------------------------------
Reporter: bmispelon | Owner: kevin_e
Type: Bug | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+------------------------------------

Comment (by anubhav9042):

Rather did that myself:
https://github.com/django/djangoproject.com/pull/68

--
Ticket URL: <https://code.djangoproject.com/ticket/21610#comment:6>

Django

unread,
Dec 23, 2013, 9:51:13 AM12/23/13
to django-...@googlegroups.com
#21610: Broken link on "Community" page
-------------------------------------+------------------------------------
Reporter: bmispelon | Owner: kevin_e
Type: Bug | Status: closed
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+------------------------------------
Changes (by Baptiste Mispelon <bmispelon@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In
[changeset:"569401fc932f5647fc3446b2fa81d693612f10fb/djangoproject.com"]:
{{{
#!CommitTicketReference repository="djangoproject.com"
revision="569401fc932f5647fc3446b2fa81d693612f10fb"
Fixed #21610 -- Removed broken link on Community page

Removed subscribing form and FAQ link and updated link for django-users
and django-developers to go to 'Mailing lists' webpage.

Thanks bmispelon for the report and claudep and anubhav9042 for the
review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21610#comment:7>

Reply all
Reply to author
Forward
0 new messages