[Django] #24017: add python_2_unicode_compatible to classes in db/migrations
Django
-------------------------------+-----------------------
Reporter: jschneier | Owner: jschneier
Type: Uncategorized | Status: new
Component: Uncategorized | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------+-----------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/24017>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: jschneier | Owner: jschneier
Type: Uncategorized | Status: assigned
Component: Uncategorized | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by jschneier):
* status: new => assigned
* needs_docs: => 0
* needs_tests: => 0
* needs_better_patch: => 0
Old description:
New description:
i was looking into an unrelated issue and noticed that
python_2_unicode_compatible wasn't applied to some classes with __str__
db/migrations.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/24017#comment:1>
Django
Reporter: jschneier | Owner: jschneier
Type: Uncategorized | Status: assigned
Component: Uncategorized | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by jschneier):
I've created a pull request here:
https://github.com/django/django/pull/3750
Let me know if I've done anything wrong, I've never contributed to django
before and was trying to follow the project/contributor guidelines. I
don't think this particular change needs tests and am not sure if it needs
a documentation update.
--
Ticket URL: <https://code.djangoproject.com/ticket/24017#comment:2>
Django
Reporter: jschneier | Owner: jschneier
Type: Bug | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* type: Uncategorized => Bug
* component: Uncategorized => Migrations
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24017#comment:3>
Django
Reporter: jschneier | Owner: jschneier
Type: Bug | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by MarkusH):
* needs_better_patch: 0 => 1
* needs_tests: 1 => 0
Comment:
Apart from the few comments and annotations I left on the pull request,
this looks ready-for-checkin.
--
Ticket URL: <https://code.djangoproject.com/ticket/24017#comment:4>
Django
Reporter: jschneier | Owner: jschneier
Type: Bug | Status: closed
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9a23470072865b7aa659e6af0b275668c85bb44d"]:
{{{
#!CommitTicketReference repository=""
revision="9a23470072865b7aa659e6af0b275668c85bb44d"
Fixed #24017 -- Added python_2_unicode_compatible in db/migrations
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24017#comment:5>