Re: [Django] #31630: Replace DatabaseFeatures.introspected_*_field_type attributes with a single attribute.

[Django]

#31630: Replace DatabaseFeatures.introspected_*_field_type attributes with a single
attribute.
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1

Comment:

As noted on the PR, I'm doing a little more work before marking this as
ready for checkin.

--
Ticket URL: <https://code.djangoproject.com/ticket/31630#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#31630: Replace DatabaseFeatures.introspected_*_field_type attributes with a single
attribute.
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 1 => 0

Comment:

I added two commits to the PR which finishes the work.

--
Ticket URL: <https://code.djangoproject.com/ticket/31630#comment:4>

[Django]

#31630: Replace DatabaseFeatures.introspected_*_field_type attributes with a single
attribute.
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by felixxm):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/31630#comment:5>

[Django]

#31630: Replace DatabaseFeatures.introspected_*_field_type attributes with a single
attribute.
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Hasan
Type: | Ramezani

Cleanup/optimization | Status: closed

Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"a7b4a04d6c54679cb0fbc8679367848bd7dae718" a7b4a04d]:
{{{
#!CommitTicketReference repository=""
revision="a7b4a04d6c54679cb0fbc8679367848bd7dae718"
Refs #31630 -- Added CharField and IntegerField to
DatabaseFeatures.introspected_field_types.

CockroachDB introspects CharField as TextField and IntegerField as
BigIntegerField.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31630#comment:8>

[Django]

#31630: Replace DatabaseFeatures.introspected_*_field_type attributes with a single
attribute.
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"e198beadad56d5fdd06756b097446b7046a84010" e198bea]:
{{{
#!CommitTicketReference repository=""
revision="e198beadad56d5fdd06756b097446b7046a84010"
Fixed #31630 -- Replaced introspection features with
DatabaseFeatures.introspected_field_types.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31630#comment:6>

[Django]

#31630: Replace DatabaseFeatures.introspected_*_field_type attributes with a single
attribute.
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"e24b63fe859c03c429ebeb7d28665f591cee22ff" e24b63fe]:
{{{
#!CommitTicketReference repository=""
revision="e24b63fe859c03c429ebeb7d28665f591cee22ff"
Refs #31630 -- Removed DatabaseFeatures.can_introspect_autofield.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31630#comment:7>