[Django] #28109: Paginator warning about unordered object list should have the appropriate stacklevel

57 views
Skip to first unread message

Django

unread,
Apr 20, 2017, 10:32:53 PM4/20/17
to django-...@googlegroups.com
#28109: Paginator warning about unordered object list should have the appropriate
stacklevel
-------------------------------------------+------------------------
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 1.11
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
Right now the warning points at Django's source which can be confusing as
exemplified by #28108.

Refs #26290.

--
Ticket URL: <https://code.djangoproject.com/ticket/28109>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 20, 2017, 10:50:39 PM4/20/17
to django-...@googlegroups.com
#28109: Paginator warning about unordered object list should have the appropriate
stacklevel
---------------------------------+------------------------------------

Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Simon Charette):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/8383 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28109#comment:1>

Django

unread,
Apr 21, 2017, 3:24:24 AM4/21/17
to django-...@googlegroups.com
#28109: Paginator warning about unordered object list should have the appropriate
stacklevel
-------------------------------------+-------------------------------------

Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* component: Uncategorized => Core (Other)
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/28109#comment:2>

Django

unread,
Apr 22, 2017, 2:09:36 PM4/22/17
to django-...@googlegroups.com
#28109: Paginator warning about unordered object list should have the appropriate
stacklevel
-------------------------------------+-------------------------------------

Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: closed
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette <charette.s@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"c0f12a098c0258eef3e9af982c17f5ef7f6c927d" c0f12a0]:
{{{
#!CommitTicketReference repository=""
revision="c0f12a098c0258eef3e9af982c17f5ef7f6c927d"
Fixed #28109 -- Corrected the stack level of unordered queryset pagination
warnings.

Refs #26290.

Thanks Tim for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28109#comment:3>

Django

unread,
Apr 22, 2017, 2:11:06 PM4/22/17
to django-...@googlegroups.com
#28109: Paginator warning about unordered object list should have the appropriate
stacklevel
-------------------------------------+-------------------------------------

Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: closed
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Simon Charette <charette.s@…>):

In [changeset:"395df007f4151390c614866d99827bbed1795a43" 395df007]:
{{{
#!CommitTicketReference repository=""
revision="395df007f4151390c614866d99827bbed1795a43"
[1.11.x] Fixed #28109 -- Corrected the stack level of unordered queryset
pagination warnings.

Refs #26290.

Thanks Tim for the review.

Backport of c0f12a098c0258eef3e9af982c17f5ef7f6c927d from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28109#comment:4>

Reply all
Reply to author
Forward
0 new messages