[Django] #28819: Django 2.0 - subclasses of Loader must provide a get_template_sources() method

48 views
Skip to first unread message

Django

unread,
Nov 20, 2017, 5:01:36 AM11/20/17
to django-...@googlegroups.com
#28819: Django 2.0 - subclasses of Loader must provide a get_template_sources()
method
-----------------------------------------+------------------------
Reporter: kakulukia | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Hi!

Im using pypugjs (https://github.com/matannoam/pypugjs) to have cleaner
templates, but with 2.0 something is broken for me and im note sure what
changed, because there is nothing serious in the release notes about the
templating system and according to git the loaders/base.py was last
touched in January this year.

So why would this break all of a sudden but still work with 1.11.7?
Can someone confirm that there is also a problem with other custom
template loaders?

--
Ticket URL: <https://code.djangoproject.com/ticket/28819>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 20, 2017, 6:30:37 AM11/20/17
to django-...@googlegroups.com
#28819: Django 2.0 - subclasses of Loader must provide a get_template_sources()
method
-------------------------------+--------------------------------------

Reporter: kakulukia | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 2.0
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Description changed by kakulukia:

Old description:

> Hi!
>
> Im using pypugjs (https://github.com/matannoam/pypugjs) to have cleaner
> templates, but with 2.0 something is broken for me and im note sure what
> changed, because there is nothing serious in the release notes about the
> templating system and according to git the loaders/base.py was last
> touched in January this year.
>
> So why would this break all of a sudden but still work with 1.11.7?
> Can someone confirm that there is also a problem with other custom
> template loaders?

New description:

Hi!

Im using pypugjs (https://github.com/matannoam/pypugjs) to have cleaner
templates, but with 2.0 something is broken for me and im note sure what
changed, because there is nothing serious in the release notes about the
templating system and according to git the loaders/base.py was last
touched in January this year.

So why would this break all of a sudden but still work with 1.11.7?
Can someone confirm that there is also a problem with other custom
template loaders?

BTW: im using the following project template: https://github.com/kakulukia
/django-default-project/ - just updating django to 2.0 inside there will
trow the mentioned error.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/28819#comment:1>

Django

unread,
Nov 20, 2017, 7:37:39 AM11/20/17
to django-...@googlegroups.com
#28819: Django 2.0 - subclasses of Loader must provide a get_template_sources()
method
-------------------------------+--------------------------------------
Reporter: kakulukia | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: 2.0
Severity: Normal | Resolution: invalid

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Tim Graham):

* status: new => closed
* resolution: => invalid


Comment:

I answered on the [https://github.com/matannoam/pypugjs/issues/25 pypugjs
issue]. In the future, please use
[wiki:TicketClosingReasons/UseSupportChannels our support channels] to ask
questions.

--
Ticket URL: <https://code.djangoproject.com/ticket/28819#comment:2>

Django

unread,
Nov 20, 2017, 7:42:38 AM11/20/17
to django-...@googlegroups.com
#28819: Django 2.0 - subclasses of Loader must provide a get_template_sources()
method
-------------------------------+--------------------------------------
Reporter: kakulukia | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: 2.0
Severity: Normal | Resolution: invalid

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by kakulukia):

okay .. its not a bug. I just didnt see deprecation warnings because they
are disabled at least in 1.11 :)
good to know!

--
Ticket URL: <https://code.djangoproject.com/ticket/28819#comment:3>

Django

unread,
Nov 14, 2019, 1:37:54 PM11/14/19
to django-...@googlegroups.com
#28819: Django 2.0 - subclasses of Loader must provide a get_template_sources()
method
-------------------------------+--------------------------------------
Reporter: Andy Grabow | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: 2.0
Severity: Normal | Resolution: invalid

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by pmourelle):

Hi there. I stumbled with similar issue trying to get django-tenant-
schemas working. The answer on issue you mentioned above is no longer
visible (404 on github), is there any chance to know what was the content
of that answer? Also, maybe for the future, would be helpful provide
content in here (besides the link for reference) for cases like this one
where an external service isn't availabale.

--
Ticket URL: <https://code.djangoproject.com/ticket/28819#comment:4>

Reply all
Reply to author
Forward
0 new messages