[Django] #26512: Add tests for the SpatialRefSysMixin.get_units() method
Django
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
The method isn't covered by tests since it's unused since
ae7cb577ddbea48aaed26cbbf69c77078a99e221. Claude said there's value in
keeping the method around though.
--
Ticket URL: <https://code.djangoproject.com/ticket/26512>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timgraham | Owner: niconoe
Type: Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by niconoe):
* owner: nobody => niconoe
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/26512#comment:1>
Django
Reporter: timgraham | Owner: niconoe
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by niconoe):
Hi, I'm a new contributor and did my best here in my pull request.
In addition to testing the class method, I updated the docstring since it
was outdated and a bit vague IMHO and fixed a small issue with it: when
GDAL was present, the unit was returned as a `float` (seems good), but as
a string when GDAL was unavailable. It's now properly casted to a float in
such cases.
Cricticism is more than welcome!
--
Ticket URL: <https://code.djangoproject.com/ticket/26512#comment:2>
Django
Reporter: timgraham | Owner: niconoe
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by niconoe):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26512#comment:3>
Django
Reporter: timgraham | Owner: niconoe
Component: GIS | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"23fbd3ff48a90b7e5d373b6fe50b65d1c48dabed" 23fbd3f]:
{{{
#!CommitTicketReference repository=""
revision="23fbd3ff48a90b7e5d373b6fe50b65d1c48dabed"
Fixed #26512 -- Added tests for SpatialRefSysMixin.get_units().
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26512#comment:4>