[Django] #24982: Split staticfiles tests into multiple files

10 views
Skip to first unread message

Django

unread,
Jun 13, 2015, 8:36:59 PM6/13/15
to django-...@googlegroups.com
#24982: Split staticfiles tests into multiple files
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.staticfiles | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
Update [https://github.com/django/django/pull/3977 an existing pull
request] per the comments.

--
Ticket URL: <https://code.djangoproject.com/ticket/24982>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 1, 2015, 7:06:54 AM7/1/15
to django-...@googlegroups.com
#24982: Split staticfiles tests into multiple files
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: MoritzS
Type: Cleanup/optimization | Status: assigned
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by MoritzS):

* owner: nobody => MoritzS
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/24982#comment:1>

Django

unread,
Jul 1, 2015, 8:07:28 AM7/1/15
to django-...@googlegroups.com
#24982: Split staticfiles tests into multiple files
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: MoritzS
Type: Cleanup/optimization | Status: assigned
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by MoritzS):

* needs_better_patch: 1 => 0


Comment:

Added PR.
The tests are now structured as follows:

`cases.py`:
{{{
class BaseStaticFilesTestCase
class StaticFilesTestCase
class BaseCollectionTestCase
class CollectionTestCase
class TestDefaults
class TestNoFilesCreated
def hashed_file_path
class TestHashedFiles
class FinderTestCase
}}}
`settings.py`:
{{{
TEST_ROOT
TESTFILES_PATH
TEST_SETTINGS
}}}
`test_finders.py`:
{{{
class TestFileSystemFinder
class TestAppDirectoriesFinder
class TestDefaultStorageFinder
class TestMiscFinder
}}}
`test_management.py`:
{{{
class TestFindStatic
class TestConfiguration
class TestCollection
class TestCollectionClear
class TestCollectionExcludeNoDefaultIgnore
class TestCollectionDryRun
class TestCollectionFilesOverride
class TestCollectionOverwriteWarning
class TestCollectionNonLocalStorage
class TestCollectionLinks
}}}
`test_storage.py`:
{{{
class TestCollectionCachedStorage
class TestCollectionManifestStorage
class TestCollectionSimpleCachedStorage
class CustomStaticFilesStorage
class TestStaticFilePermissions
}}}
`test_templatetags.py`:
{{{
class TestTemplateTag
}}}
`test_views.py`:
{{{
class TestServeStatic
class TestServeDisabled
class TestServeStaticWithDefaultURL
class TestServeStaticWithURLHelper
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24982#comment:2>

Django

unread,
Jul 1, 2015, 9:43:14 AM7/1/15
to django-...@googlegroups.com
#24982: Split staticfiles tests into multiple files
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: MoritzS
Type: Cleanup/optimization | Status: closed
Component: contrib.staticfiles | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"b35b43dff81d46e930ffa1e05eb50968b8557102" b35b43d]:
{{{
#!CommitTicketReference repository=""
revision="b35b43dff81d46e930ffa1e05eb50968b8557102"
Fixed #24982 -- Split staticfiles tests into multiple files
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24982#comment:3>

Reply all
Reply to author
Forward
0 new messages