[Django] #27156: Setting HttpRequest.encoding should clear GET
Django
-----------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Discovered in #27113, commit d7a4b156d935ffcb8cdd9290688457453fc06b24
broke clearing of `request.GET` when `request.encoding` changes. I think
the line in the `encoding.settr` needs to use `del self.GET` instead of
`del self._get`.
--
Ticket URL: <https://code.djangoproject.com/ticket/27156>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timgraham | Owner: PREM1980
Type: Bug | Status: assigned
Component: HTTP handling | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by PREM1980):
* owner: nobody => PREM1980
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27156#comment:1>
Django
Reporter: Tim Graham | Owner: PREMANAND
Type: Bug | Status: assigned
Component: HTTP handling | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by PREMANAND):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27156#comment:2>
Django
Reporter: Tim Graham | Owner: PREMANAND
Type: Bug | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by PREMANAND):
https://github.com/django/django/pull/7569
--
Ticket URL: <https://code.djangoproject.com/ticket/27156#comment:3>
Django
Reporter: Tim Graham | Owner: PREMANAND
Type: Bug | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
Comment:
The test doesn't pass on Python 2.
--
Ticket URL: <https://code.djangoproject.com/ticket/27156#comment:4>
Django
Reporter: Tim Graham | Owner: PREMANAND
Component: HTTP handling | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"371adc472a2a1f09923101e3c4fda60cdff96028" 371adc4]:
{{{
#!CommitTicketReference repository=""
revision="371adc472a2a1f09923101e3c4fda60cdff96028"
Fixed #27156 -- Made changing HttpRequest.encoding clear GET.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27156#comment:5>