[Django] #32201: remove obsolete isort:skip's

16 views
Skip to first unread message

Django

unread,
Nov 16, 2020, 6:17:46 PM11/16/20
to django-...@googlegroups.com
#32201: remove obsolete isort:skip's
------------------------------------------------+------------------------
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
Some `isort:skip` comments, particularly in the database backends
([https://github.com/cockroachdb/django-cockroachdb/pull/193/files
example]), are obsolete as of isort 5.0.

--
Ticket URL: <https://code.djangoproject.com/ticket/32201>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 17, 2020, 12:07:39 AM11/17/20
to django-...@googlegroups.com
#32201: remove obsolete isort:skip's
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: seamus-
Type: | quinn
Cleanup/optimization | Status: assigned

Component: Core (Other) | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by seamus-quinn):

* owner: nobody => seamus-quinn
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/32201#comment:1>

Django

unread,
Nov 17, 2020, 12:39:03 AM11/17/20
to django-...@googlegroups.com
#32201: remove obsolete isort:skip's
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: seamus-
Type: | quinn
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted


Comment:

seamus-quinn, please audit all `isort:skip` comments not only in
`django/db/backends` (e.g. in `django/template/__init__.py`).

--
Ticket URL: <https://code.djangoproject.com/ticket/32201#comment:2>

Django

unread,
Nov 19, 2020, 12:28:14 AM11/19/20
to django-...@googlegroups.com
#32201: remove obsolete isort:skip's
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Seamus
Type: | Quinn
Cleanup/optimization | Status: assigned

Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* stage: Accepted => Ready for checkin


Comment:

[https://github.com/django/django/pull/13687 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/32201#comment:3>

Django

unread,
Nov 19, 2020, 12:36:01 AM11/19/20
to django-...@googlegroups.com
#32201: remove obsolete isort:skip's
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Seamus
Type: | Quinn
Cleanup/optimization | Status: closed

Component: Core (Other) | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"9f72b0970db4be76d14bd7be5a21582d2cc484bc" 9f72b09]:
{{{
#!CommitTicketReference repository=""
revision="9f72b0970db4be76d14bd7be5a21582d2cc484bc"
Fixed #32201 -- Removed obsolete isort:skip's.

Obsolete as of isort 5.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32201#comment:4>

Reply all
Reply to author
Forward
0 new messages