[Django] #27787: call_command() should validate the arguments it receives

12 views
Skip to first unread message

Django

unread,
Jan 27, 2017, 1:25:16 PM1/27/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim | Owner: nobody
Graham |
Type: | Status: new
Cleanup/optimization |
Component: Core | Version: master
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
In #27769 it was observed that `call_command()` doesn't reject unknown
options. In that case, `noinput=True` was passed rather than
`interactive=False`. It would be nice if such errors didn't pass silently.

--
Ticket URL: <https://code.djangoproject.com/ticket/27787>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 27, 2017, 1:31:29 PM1/27/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Srinivas Reddy Thatiparthy):

* owner: nobody => Srinivas Reddy Thatiparthy
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:1>

Django

unread,
Jan 28, 2017, 5:40:08 AM1/28/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Chandrakant Kumar):

* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/7976

--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:2>

Django

unread,
Jan 28, 2017, 7:28:28 AM1/28/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* needs_tests: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:3>

Django

unread,
Jan 28, 2017, 2:06:00 PM1/28/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Chandrakant Kumar):

* needs_tests: 1 => 0


Comment:

https://github.com/django/django/pull/7979

--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:4>

Django

unread,
Jan 31, 2017, 7:45:07 PM1/31/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1


Comment:

The patch is still not ready for review given tests aren't passing and
release notes about possible backwards incompatibilities are missing.

--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:5>

Django

unread,
Feb 18, 2017, 4:52:24 AM2/18/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Chandrakant Kumar):

* needs_better_patch: 1 => 0


Comment:

https://github.com/django/django/pull/8036

--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:6>

Django

unread,
Feb 18, 2017, 4:53:04 AM2/18/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner:
Type: | Chandrakant Kumar

Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Chandrakant Kumar):

* owner: Srinivas Reddy Thatiparthy => Chandrakant Kumar


--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:7>

Django

unread,
Jun 16, 2017, 11:07:37 AM6/16/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner:
Type: | Chandrakant Kumar
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"f6800a081afa27eaee9229ad5ccfd86c6c61496d" f6800a08]:
{{{
#!CommitTicketReference repository=""
revision="f6800a081afa27eaee9229ad5ccfd86c6c61496d"
Refs #27787 -- Corrected or removed invalid call_command() options.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:8>

Django

unread,
Jun 16, 2017, 11:58:59 AM6/16/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner:
Type: | Chandrakant Kumar
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:9>

Django

unread,
Jun 16, 2017, 9:54:36 PM6/16/17
to django-...@googlegroups.com
#27787: call_command() should validate the arguments it receives
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner:
Type: | Chandrakant Kumar
Cleanup/optimization | Status: closed

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"2b09e4c88e96cb03b29f5a6b0e4838ab4271e631" 2b09e4c8]:
{{{
#!CommitTicketReference repository=""
revision="2b09e4c88e96cb03b29f5a6b0e4838ab4271e631"
Fixed #27787 -- Made call_command() validate the options it receives.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27787#comment:10>

Reply all
Reply to author
Forward
0 new messages