[Django] #33044: pyproject.toml breaks pip install into user site directory with editable source
Django
source
-------------------------------------------+------------------------
Reporter: Tim Graham | Owner: nobody
Type: Bug | Status: new
Component: Packaging | Version: dev
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
The addition of [https://github.com/django/django/pull/13994/files
pyproject.toml] in [https://github.com/django/django/pull/13994 PR 13994]
causes `pip install -e` into a user site directory to fail. See
[https://github.com/django/django/pull/13994#issuecomment-859975234 thread
on the original PR].
Nick Pope
[https://github.com/django/django/pull/13994#issuecomment-870861490
proposes three possible options]:
1. The documentation approach -- using `--no-build-isolation` with `pip
install --editable --user` will work.
2. Add the following hack to setup.py in Django:
{{{ #!python
import site
import sys
site.ENABLE_USER_SITE = '--user' in sys.argv[1:]
}}}
3. Revert the change that added build-system isolation until there is a
blessed solution for editable installs with PEP 517.
--
Ticket URL: <https://code.djangoproject.com/ticket/33044>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
source
Reporter: Tim Graham | Owner: nobody
Type: Bug | Status: new
Component: Packaging | Version: dev
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* cc: Florian Apolloner, Chris Jerdonek, Nick Pope (added)
* stage: Unreviewed => Accepted
Comment:
Agreed, we should do something. I'd prefer the second option.
--
Ticket URL: <https://code.djangoproject.com/ticket/33044#comment:1>
Django
source
Reporter: Tim Graham | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: Packaging | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* owner: nobody => Carlton Gibson
* status: new => assigned
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/14820 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33044#comment:2>
Django
source
Reporter: Tim Graham | Owner: Carlton
| Gibson
Component: Packaging | Version: dev
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"c1d50b901b50672a46e7e5fe473c14da1616fc4e" c1d50b90]:
{{{
#!CommitTicketReference repository=""
revision="c1d50b901b50672a46e7e5fe473c14da1616fc4e"
Fixed #33044 -- Reallowed editable install into user site directory.
Regression in f8f35e8c530aaf440fa8160327461460d79f6db2.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33044#comment:3>