[Django] #29227: Allow BooleanField to be null=True

12 views
Skip to first unread message

Django

unread,
Mar 16, 2018, 12:03:28 PM3/16/18
to django-...@googlegroups.com
#29227: Allow BooleanField to be null=True
-------------------------------------+-------------------------------------
Reporter: Tim | Owner: Tim Graham
Graham |
Type: | Status: assigned
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
This will remove the wart of `NullBooleanField` and help solve other
issues like #23130.

--
Ticket URL: <https://code.djangoproject.com/ticket/29227>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 16, 2018, 12:54:29 PM3/16/18
to django-...@googlegroups.com
#29227: Allow BooleanField to be null=True
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Tim
Type: | Graham
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/8467 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/29227#comment:1>

Django

unread,
Mar 20, 2018, 1:07:18 PM3/20/18
to django-...@googlegroups.com
#29227: Allow BooleanField to be null=True
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Tim
Type: | Graham
Cleanup/optimization | Status: closed

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"5fa4f40f45fcdbb7e48489ed3039a314b5c961d0" 5fa4f40f]:
{{{
#!CommitTicketReference repository=""
revision="5fa4f40f45fcdbb7e48489ed3039a314b5c961d0"
Fixed #29227 -- Allowed BooleanField to be null=True.

Thanks Lynn Cyrin for contributing to the patch, and Nick Pope for review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29227#comment:2>

Django

unread,
Mar 20, 2018, 1:07:18 PM3/20/18
to django-...@googlegroups.com
#29227: Allow BooleanField to be null=True
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Tim
Type: | Graham
Cleanup/optimization | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"6421bd702fb8205c6b91395d087dc34d179f0c35" 6421bd70]:
{{{
#!CommitTicketReference repository=""
revision="6421bd702fb8205c6b91395d087dc34d179f0c35"
Refs #29227 -- Made inspectdb generate BooleanField(null=True) rather than
NullBooleanField.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29227#comment:3>

Django

unread,
Mar 20, 2018, 1:07:18 PM3/20/18
to django-...@googlegroups.com
#29227: Allow BooleanField to be null=True
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Tim
Type: | Graham
Cleanup/optimization | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"281c0223b376d6fa1a11e0726d824ed35cfe7524" 281c022]:
{{{
#!CommitTicketReference repository=""
revision="281c0223b376d6fa1a11e0726d824ed35cfe7524"
Refs #29227 -- Simplified NullBooleanField by making it subclass
BooleanField.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29227#comment:4>

Reply all
Reply to author
Forward
0 new messages