[Django] #30193: Changes to PostgreSQL ensure_timezone caused unnecessary roundtrips to the database on connection initialization.

3 views
Skip to first unread message

Django

unread,
Feb 19, 2019, 2:23:28 PM2/19/19
to django-...@googlegroups.com
#30193: Changes to PostgreSQL ensure_timezone caused unnecessary roundtrips to the
database on connection initialization.
-------------------------------------+-------------------------------------
Reporter: Simon | Owner: nobody
Charette |
Type: Bug | Status: assigned
Component: Database | Version: 2.2
layer (models, ORM) |
Severity: Release | Keywords:
blocker |
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes were introduced in a96b9019320ed8236659ee520a7a017c1bafbc6f to
deal with https://code.djangoproject.com/ticket/28478#comment:13 as
[https://github.com/django/django/pull/10840#issuecomment-465242160
reported on Github].

--
Ticket URL: <https://code.djangoproject.com/ticket/30193>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 19, 2019, 2:48:58 PM2/19/19
to django-...@googlegroups.com
#30193: Changes to PostgreSQL ensure_timezone caused unnecessary roundtrips to the
database on connection initialization.
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: assigned
Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/30193#comment:1>

Django

unread,
Feb 20, 2019, 4:54:05 AM2/20/19
to django-...@googlegroups.com
#30193: Changes to PostgreSQL ensure_timezone caused unnecessary roundtrips to the
database on connection initialization.
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: assigned

Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/30193#comment:2>

Django

unread,
Feb 20, 2019, 5:00:58 AM2/20/19
to django-...@googlegroups.com
#30193: Changes to PostgreSQL ensure_timezone caused unnecessary roundtrips to the
database on connection initialization.
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: closed

Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson <carlton.gibson@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"7071f8f2729295b0da77b6c651966dc32c71f1ab" 7071f8f2]:
{{{
#!CommitTicketReference repository=""
revision="7071f8f2729295b0da77b6c651966dc32c71f1ab"
Fixed #30193, Refs #28478 -- Avoided PostgreSQL connection health checks
on initialization.

This addressed a regression introduced by
a96b9019320ed8236659ee520a7a017c1bafbc6f as identified by Ran Benita.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30193#comment:3>

Django

unread,
Feb 20, 2019, 5:01:47 AM2/20/19
to django-...@googlegroups.com
#30193: Changes to PostgreSQL ensure_timezone caused unnecessary roundtrips to the
database on connection initialization.
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: nobody
Type: Bug | Status: closed
Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson <carlton.gibson@…>):

In [changeset:"7f25344c2e69454bb69ec6100a1bc0af6cee6d70" 7f25344c]:
{{{
#!CommitTicketReference repository=""
revision="7f25344c2e69454bb69ec6100a1bc0af6cee6d70"
[2.2.x] Fixed #30193, Refs #28478 -- Avoided PostgreSQL connection health
checks on initialization.

This addressed a regression introduced by
a96b9019320ed8236659ee520a7a017c1bafbc6f as identified by Ran Benita.

Backport of 7071f8f2729295b0da77b6c651966dc32c71f1ab from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30193#comment:4>

Reply all
Reply to author
Forward
0 new messages