[Django] #26285: Deprecate the MySQL specific __search lookup

10 views
Skip to first unread message

Django

unread,
Feb 26, 2016, 12:40:53 PM2/26/16
to django-...@googlegroups.com
#26285: Deprecate the MySQL specific __search lookup
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Found the implementation in Marc Taymlyn's
[https://github.com/django/django/pull/4726 branch for PostgreSQL full
text text]. It should have a separate ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/26285>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 26, 2016, 1:52:16 PM2/26/16
to django-...@googlegroups.com
#26285: Deprecate the MySQL specific __search lookup
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/6208 PR]. As noted there, a
remaining problem is that the `__search` lookup is
[https://github.com/django/django/blob/d5f89ff6e873dbb2890ed05ce2aeae628792c8f7/django/contrib/admin/options.py#L888-L889
used by the admin]
for the `search_fields = ['@fieldname']` syntax. I think #26184 would
allow removing that code.

If we don't want to make that ticket a prerequisite of this one, I suppose
we could leave that code for now, even if the `search` lookup is removed
from Django itself.

--
Ticket URL: <https://code.djangoproject.com/ticket/26285#comment:1>

Django

unread,
Mar 2, 2016, 3:34:37 PM3/2/16
to django-...@googlegroups.com
#26285: Deprecate the MySQL specific __search lookup
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"8ddc79a7991685b9463b4f4db43fc4c064bc49f8" 8ddc79a]:
{{{
#!CommitTicketReference repository=""
revision="8ddc79a7991685b9463b4f4db43fc4c064bc49f8"
Fixed #26285 -- Deprecated the MySQL-specific __search lookup.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26285#comment:2>

Django

unread,
Jan 17, 2017, 10:09:52 PM1/17/17
to django-...@googlegroups.com
#26285: Deprecate the MySQL specific __search lookup
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: nobody

Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"5139832398624be75ee5361a6fac9348fdb61093" 5139832]:
{{{
#!CommitTicketReference repository=""
revision="5139832398624be75ee5361a6fac9348fdb61093"
Refs #26285 -- Removed MySQL __search lookup per deprecation timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26285#comment:3>

Django

unread,
Feb 21, 2017, 1:16:47 PM2/21/17
to django-...@googlegroups.com
#26285: Deprecate the MySQL specific __search lookup
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"0a0c24581ed7d75f68b33707c3a55eb775385cd1" 0a0c245]:
{{{
#!CommitTicketReference repository=""
revision="0a0c24581ed7d75f68b33707c3a55eb775385cd1"
Refs #26285 -- Removed postgresql's unused
DatabaseOperations.fulltext_search_sql().

Should have been removed in 5139832398624be75ee5361a6fac9348fdb61093.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26285#comment:4>

Reply all
Reply to author
Forward
0 new messages