[Django] #30400: Improve typography of user facing strings
Django
------------------------------------------------+------------------------
Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Inspired by comment: https://code.djangoproject.com/ticket/30399#comment:2
Prefer:
- `“”` for quotes
- `’` for contractions
- `—` rather than `--`
- `…` rather than `...`
--
Ticket URL: <https://code.djangoproject.com/ticket/30400>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Jon Dufresne | Owner: nobody
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Jon Dufresne):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
Comment:
https://github.com/django/django/pull/11281
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:1>
Django
Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* stage: Unreviewed => Accepted
Comment:
Agreed, but we have to skip all messages that can appear in a shell output
(see #30184).
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* owner: nobody => Jon Dufresne
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz):
As for me, #30184 is hopefully not the last word on this issue. Preventing
all users from having good typographic output (that is real readability
improvements) just because some systems will not make the effort to
transition to UTF-8 is not fair.
As we are wrapping those outputs anyway, I think that we should be able to
detect the output encoding, and add some ascii simplification/conversion
when the output does not support UTF-8.
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Nick Pope):
Agreed - It seems a shame that we can't have nice things because the
Windows Command Prompt has been neglected for so long.
There is an interesting [https://bit.ly/2GBAJY6 article] on how this is
already being fixed, but it will take time until the majority of users do
not have a broken command prompt.
I was already looking into sprucing up some of the command output and was
considering the exact same possibility of substituting some ASCII
alternatives on terminals that do not support UTF-8. Give me a few weeks
and I'll resurrect my branch for this to see if there is a possible way
forward.
In the meantime, we should stick with the policy of not supporting unicode
in shell output.
Also, out of interest, we only support Python 3.6+ for Django 3.0 which
includes [https://docs.python.org/3/whatsnew/3.6.html#pep-528-change-
windows-console-encoding-to-utf-8 PEP 528] and
[https://docs.python.org/3/whatsnew/3.6.html#pep-529-change-windows-
filesystem-encoding-to-utf-8 PEP 529] and this may mean that issues such
as #30184 and #30324 become a thing of the past anyway. I haven't tested
this to make sure though, and the ability to disable unicode shell output
would be a good idea anyway.
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
+1 there. We should be able to push users forward at this point in
history.
Not exactly the same issue but we had a user on Django Dev hitting a
unicode error on macOS too, which means they’d set a non-unicode locale
(for unknown reason). I feel like we should be able to emit a decent
warning in this kind of case linking to a doc explaining what they need to
do. (I’ve found myself on servers with broken/primitive locales plenty of
times too… similar would help there.)
Anyhow, that’s just emoting at this point.
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jon Dufresne):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"42b9a23267f14be39b9b00958e18d5746783208e" 42b9a232]:
{{{
#!CommitTicketReference repository=""
revision="42b9a23267f14be39b9b00958e18d5746783208e"
Fixed #30400 -- Improved typography of user facing strings.
Thanks Claude Paroz for assistance with translations.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"0dafadadb924e09ffd43287604cb4c2c6e353891" 0dafada]:
{{{
#!CommitTicketReference repository=""
revision="0dafadadb924e09ffd43287604cb4c2c6e353891"
Refs #30400 -- Improved typography of user facing strings in admin
changelist.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"dfb9ae1d23662f7bfc6a28c2b726e2473e0cc48b" dfb9ae1d]:
{{{
#!CommitTicketReference repository=""
revision="dfb9ae1d23662f7bfc6a28c2b726e2473e0cc48b"
Refs #30400 -- Improved typography in admin_doc/missing_docutils.html.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"0e6fa65ffd9abf707e6781de019b76cc2e3cd787" 0e6fa65f]:
{{{
#!CommitTicketReference repository=""
revision="0e6fa65ffd9abf707e6781de019b76cc2e3cd787"
Refs #30400 -- Improved typography in debug and csrf templates.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30400#comment:12>