[Django] #24125: TemplateDetailView in admindocs requires a single Django templates engine
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Component: | Version: master
contrib.admindocs |
Severity: Release | Keywords: multiple-template-
blocker | engines
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
`TemplateDetailView.get_context_data()` calls `Engine.get_default()` which
raises `ImproperlyConfigured` if zero or several Django templates engines
are configured.
This limitation should either be lifted or documented. Gracefully showing
an error message would already be better than failing with an uncaught
exception.
--
Ticket URL: <https://code.djangoproject.com/ticket/24125>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Severity: Release blocker | Resolution:
Keywords: multiple-template- | Triage Stage:
engines | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Aymeric Augustin <aymeric.augustin@…>):
In [changeset:"511a53b3142551a1bc3093ed1b6655f57634f510"]:
{{{
#!CommitTicketReference repository=""
revision="511a53b3142551a1bc3093ed1b6655f57634f510"
Avoided exceptions in admindocs' template detail view.
This is marginally better than crashing when several Django template
engines are configured in a project.
Refs #24125.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: multiple-template- | Triage Stage: Accepted
engines 1.8 |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* keywords: multiple-template-engines => multiple-template-engines 1.8
* severity: Release blocker => Normal
* stage: Unreviewed => Accepted
Comment:
This view seems pretty obscure and of limited use. I'm going to demote
from a release blocker and tag it "1.8" instead so we make sure to
document the limitation if no one cares to write a patch by then.
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: multiple-template- | Triage Stage: Accepted
engines 1.8 |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
Yes, since it doesn't crash anymore, it isn't a blocker.
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: multiple-template- | Triage Stage: Accepted
engines |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* keywords: multiple-template-engines 1.8 => multiple-template-engines
Comment:
I don't think so many people will hit this issue that it's even worth
documenting.
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: multiple-template- | Triage Stage: Accepted
engines |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
Fine.
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner:
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution:
Keywords: multiple-template- | Triage Stage: Accepted
engines |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => kairichard
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner:
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution:
Keywords: multiple-template- | Triage Stage: Accepted
engines |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
As duplicate ticket #24957 shows, at least one person has noticed.
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner:
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution:
Keywords: multiple-template- | Triage Stage: Accepted
engines |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by timgraham):
It was the person working on this ticket who didn't realize the purpose of
it.
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner:
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution:
Keywords: multiple-template- | Triage Stage: Accepted
engines |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"3c593ba79e5bdee46419e2aa6b14e7ce8bc01758" 3c593ba7]:
{{{
#!CommitTicketReference repository=""
revision="3c593ba79e5bdee46419e2aa6b14e7ce8bc01758"
Refs #24125 -- Added admin_docs tests for multiple template engines.
This adds a test for 511a53b3142551a1bc3093ed1b6655f57634f510
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:9>
Django
-------------------------------------+-------------------------------------
| Richard König
Type: Bug | Status: closed
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution: wontfix
Keywords: multiple-template- | Triage Stage: Accepted
engines |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => wontfix
Comment:
Replying to [comment:4 Tim Graham]:
> I don't think so many people will hit this issue that it's even worth
documenting.
I agree with Tim.
--
Ticket URL: <https://code.djangoproject.com/ticket/24125#comment:10>