[Django] #25958: Deprecate skip_validation in BaseCommand

2 views
Skip to first unread message

Django

unread,
Dec 21, 2015, 9:54:32 AM12/21/15
to django-...@googlegroups.com
#25958: Deprecate skip_validation in BaseCommand
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core | Version: master
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
The deprecation for
[https://github.com/django/django/blob/541000773a19d829a46fd4bec3655dca38a95551/django/core/management/base.py#L338
skip_validation] was missed when the system check framework was merged in
1.7.


See the [https://docs.djangoproject.com/en/dev/internals/contributing
/writing-code/submitting-patches/#deprecating-a-feature Deprecating a
feature] checklist for tips.

--
Ticket URL: <https://code.djangoproject.com/ticket/25958>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 21, 2015, 2:08:05 PM12/21/15
to django-...@googlegroups.com
#25958: Deprecate skip_validation in BaseCommand
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by timgraham):

Actually, it might be fine to skip a deprecation as `skip_validation` was
never documented.

--
Ticket URL: <https://code.djangoproject.com/ticket/25958#comment:1>

Django

unread,
Dec 21, 2015, 2:34:00 PM12/21/15
to django-...@googlegroups.com
#25958: Remove support for skip_validation in BaseCommand.execute(**options)

-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/5847 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/25958#comment:2>

Django

unread,
Dec 21, 2015, 3:28:11 PM12/21/15
to django-...@googlegroups.com
#25958: Remove support for skip_validation in BaseCommand.execute(**options)
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by charettes):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/25958#comment:3>

Django

unread,
Dec 21, 2015, 5:26:50 PM12/21/15
to django-...@googlegroups.com
#25958: Remove support for skip_validation in BaseCommand.execute(**options)
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"b10f66831ba2fc68901bc674104a76eb112ee52a" b10f6683]:
{{{
#!CommitTicketReference repository=""
revision="b10f66831ba2fc68901bc674104a76eb112ee52a"
Fixed #25958 -- Removed support for 'skip_validation' in
BaseCommand.execute(**options).
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25958#comment:4>

Reply all
Reply to author
Forward
0 new messages