Re: [Django] #5372: [newforms-admin] - caching of sql query for inlines

20 views
Skip to first unread message

Django

unread,
Apr 1, 2012, 4:22:17 AM4/1/12
to django-...@googlegroups.com
#5372: [newforms-admin] - caching of sql query for inlines
-------------------------------------+-------------------------------------
Reporter: anonymous | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: newforms-
Severity: Normal | admin
Keywords: nfa-someday | Resolution:
newforms, admin, inlines | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by anonymous):

[http://www.rolexreplicaltd.org/patek-philippe-c-183.html patek philippe
replica]

--
Ticket URL: <https://code.djangoproject.com/ticket/5372#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 9, 2012, 5:58:46 AM4/9/12
to django-...@googlegroups.com
#5372: [newforms-admin] - caching of sql query for inlines
-------------------------------------+-------------------------------------
Reporter: anonymous | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: newforms-
Severity: Normal | admin
Keywords: nfa-someday | Resolution:
newforms, admin, inlines | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by anonymous):

[http://www.replicawatchesuksale.co.uk/ replica watches] n

Django

unread,
Oct 4, 2014, 11:35:02 PM10/4/14
to django-...@googlegroups.com
#5372: Cache inline ForeignKey options

-------------------------------------+-------------------------------------
Reporter: anonymous | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: newforms-
Component: contrib.admin | admin
Severity: Normal | Resolution:
Keywords: nfa-someday | Triage Stage: Accepted
newforms, admin, inlines | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by collinanderson):

* type: New feature => Cleanup/optimization


Comment:

actually, a `prefetch_related()` call might work just as well.

Django

unread,
Nov 25, 2014, 5:32:18 PM11/25/14
to django-...@googlegroups.com
#5372: Cache inline ForeignKey options
-------------------------------------+-------------------------------------
Reporter: anonymous | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: newforms-
Component: contrib.admin | admin
Severity: Normal | Resolution:
Keywords: nfa-someday | Triage Stage: Accepted
newforms, admin, inlines | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by martinblech):

I did some work on this branch:
https://github.com/martinblech/django/tree/ticket_5372
Does it make sense?

--
Ticket URL: <https://code.djangoproject.com/ticket/5372#comment:11>

Django

unread,
Nov 25, 2014, 5:48:34 PM11/25/14
to django-...@googlegroups.com
#5372: Cache inline ForeignKey options
-------------------------------------+-------------------------------------
Reporter: anonymous | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: newforms-
Component: contrib.admin | admin
Severity: Normal | Resolution:
Keywords: nfa-someday | Triage Stage: Accepted
newforms, admin, inlines | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by charettes):

I turned your branch into [https://github.com/django/django/pull/3623 a
PR] for easier reviewing and testing.

--
Ticket URL: <https://code.djangoproject.com/ticket/5372#comment:12>

Django

unread,
Nov 25, 2014, 6:07:16 PM11/25/14
to django-...@googlegroups.com
#5372: Cache inline ForeignKey options
-------------------------------------+-------------------------------------
Reporter: anonymous | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: newforms-
Component: contrib.admin | admin
Severity: Normal | Resolution:
Keywords: nfa-someday | Triage Stage: Accepted
newforms, admin, inlines | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by charettes):

As pointed out on Github the `prefetch_related()` approach won't work
until inline formsets are taught how to deal with it (#18597).

--
Ticket URL: <https://code.djangoproject.com/ticket/5372#comment:13>

Django

unread,
Jan 26, 2015, 11:47:59 AM1/26/15
to django-...@googlegroups.com
#5372: Cache inline ForeignKey options
-------------------------------------+-------------------------------------
Reporter: anonymous | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: newforms-
Component: contrib.admin | admin
Severity: Normal | Resolution:
Keywords: nfa-someday | Triage Stage: Accepted
newforms, admin, inlines |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by collinanderson):

* cc: cmawebsite@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/5372#comment:14>

Reply all
Reply to author
Forward
0 new messages