[Django] #27815: contrib.auth.views.LoginView doesn't pass request object to AuthenticationForm

[Django]

#27815: contrib.auth.views.LoginView doesn't pass request object to
AuthenticationForm
-------------------------------------+-------------------------------------
Reporter: zgyarmati | Owner: zgyarmati
Type: Bug | Status: assigned
Component: | Version: 1.11
contrib.auth | Keywords: request, LoginView,
Severity: Normal | authenticate
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
The request object isn't passed to the LoginView's form_class
'AuthenticationForm' and hence it's not passed to the auth backend's
authenticate() method, because LoginView lacks the get_form_kwargs()
method override.

--
Ticket URL: <https://code.djangoproject.com/ticket/27815>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#27815: contrib.auth.views.LoginView doesn't pass request object to
AuthenticationForm
-------------------------------------+-------------------------------------
Reporter: zgyarmati | Owner: zgyarmati
Type: Bug | Status: assigned

Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: request, LoginView, | Triage Stage: Accepted
authenticate |
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Claude Paroz):

* severity: Normal => Release blocker
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/27815#comment:1>

[Django]

#27815: contrib.auth.views.LoginView doesn't pass request object to
AuthenticationForm
-------------------------------------+-------------------------------------
Reporter: zgyarmati | Owner: zgyarmati
Type: Bug | Status: assigned

Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: request, LoginView, | Triage Stage: Accepted
authenticate |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by zgyarmati):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/8029 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27815#comment:2>

[Django]

#27815: contrib.auth.views.LoginView doesn't pass request object to
AuthenticationForm
-------------------------------------+-------------------------------------
Reporter: zgyarmati | Owner: zgyarmati
Type: Bug | Status: assigned

Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution:

Keywords: request, LoginView, | Triage Stage: Ready for
authenticate | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/27815#comment:3>

[Django]

#27815: contrib.auth.views.LoginView doesn't pass request object to
AuthenticationForm
-------------------------------------+-------------------------------------
Reporter: zgyarmati | Owner: zgyarmati

Type: Bug | Status: closed
Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution: fixed

Keywords: request, LoginView, | Triage Stage: Ready for
authenticate | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"41ba27fefdd313333d94408802afff36a9eedb83" 41ba27fe]:
{{{
#!CommitTicketReference repository=""
revision="41ba27fefdd313333d94408802afff36a9eedb83"
Fixed #27815 -- Made LoginView pass the request kwarg to
AuthenticationForm.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27815#comment:4>

[Django]

#27815: contrib.auth.views.LoginView doesn't pass request object to
AuthenticationForm
-------------------------------------+-------------------------------------
Reporter: zgyarmati | Owner: zgyarmati

Type: Bug | Status: closed
Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: request, LoginView, | Triage Stage: Ready for
authenticate | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"f94e1a5de4c379575e3d9cf54f0a70671acba72b" f94e1a5d]:
{{{
#!CommitTicketReference repository=""
revision="f94e1a5de4c379575e3d9cf54f0a70671acba72b"
[1.11.x] Fixed #27815 -- Made LoginView pass the request kwarg to
AuthenticationForm.

Backport of 41ba27fefdd313333d94408802afff36a9eedb83 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27815#comment:5>

[Django]

#27815: contrib.auth.views.LoginView doesn't pass request object to
AuthenticationForm
-------------------------------------+-------------------------------------
Reporter: zgyarmati | Owner: zgyarmati

Type: Bug | Status: closed
Component: contrib.auth | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: request, LoginView, | Triage Stage: Ready for
authenticate | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"854f6950149e84d4c4bcbe98b7459084b44a6b9a" 854f695]:
{{{
#!CommitTicketReference repository=""
revision="854f6950149e84d4c4bcbe98b7459084b44a6b9a"
Refs #27815 -- Reordered LoginView.get_form_kwargs().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27815#comment:6>