[Django] #28190: Re-iterate the point about absolute/relative paths in the 'include' templatetag example
Django
templatetag example
-----------------------------------------+------------------------
Reporter: Anupam | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Minor point but I feel it is worth re-iterating that the example
([https://docs.djangoproject.com/en/1.11/ref/templates/builtins/#include])
is using an absolute path and folks should prefix "./" if the template
being referenced is in the same directory as the template that is
referencing it.
Github issue : https://github.com/django/django/pull/8483
(Apologies in advance if I made any formatting errors)
--
Ticket URL: <https://code.djangoproject.com/ticket/28190>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------------+------------------------------------
Reporter: Anupam | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
* component: Uncategorized => Documentation
* has_patch: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Old description:
> Minor point but I feel it is worth re-iterating that the example
> ([https://docs.djangoproject.com/en/1.11/ref/templates/builtins/#include])
> is using an absolute path and folks should prefix "./" if the template
> being referenced is in the same directory as the template that is
> referencing it.
>
> Github issue : https://github.com/django/django/pull/8483
>
> (Apologies in advance if I made any formatting errors)
New description:
Minor point but I feel it is worth re-iterating that the example
([https://docs.djangoproject.com/en/1.11/ref/templates/builtins/#include])
is using an absolute path and folks should prefix "./" if the template
being referenced is in the same directory as the template that is
referencing it.
[https://github.com/django/django/pull/8483 PR]
--
Comment:
As I said on the PR, I'm not sure if "absolute path" is good terminology
to use, considering that the given path is usually relative to the
directory specified by a template loader, however, some clarifications
could be made.
--
Ticket URL: <https://code.djangoproject.com/ticket/28190#comment:1>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.11
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"1f2e4f9cfe26dd9ad1fc85375c1dce38c65bbe6b" 1f2e4f9c]:
{{{
#!CommitTicketReference repository=""
revision="1f2e4f9cfe26dd9ad1fc85375c1dce38c65bbe6b"
Fixed #28190 -- Clarifed how include/extends treat template names.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28190#comment:2>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.11
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"9a3bcaf46aba223789f42df8bc08348694d9f16f" 9a3bcaf4]:
{{{
#!CommitTicketReference repository=""
revision="9a3bcaf46aba223789f42df8bc08348694d9f16f"
[1.11.x] Fixed #28190 -- Clarifed how include/extends treat template
names.
Backport of 1f2e4f9cfe26dd9ad1fc85375c1dce38c65bbe6b from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28190#comment:3>