[Django] #26424: Allow URLValidator to skip schemes validation
Django
----------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+------------------------
As proposed by Claude in #26418, "provide some special value for `scheme`,
like `'__all__'`, to allow for all possible schemes (in the same spirit as
the `ModelForm` `fields` / `exclude` attributes).
--
Ticket URL: <https://code.djangoproject.com/ticket/26424>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timgraham | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
It's not exactly about skipping scheme validation, but a minimal
validation (e.g. all ascii letters and maximal length).
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:1>
Django
Reporter: timgraham | Owner: burhan
Type: New feature | Status: assigned
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by burhan):
* owner: nobody => burhan
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:2>
Django
Reporter: timgraham | Owner: burhan
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/6388 PR] with some comments for
improvement.
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:3>
Django
Reporter: timgraham | Owner: burhan
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by burhan):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:4>
Django
Reporter: timgraham | Owner: burhan
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:5>
Django
Reporter: timgraham | Owner: burhan
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:6>
Django
Reporter: timgraham | Owner: burhan
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:7>
Django
Reporter: Tim Graham | Owner: Baptiste
| Mispelon
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Baptiste Mispelon):
* owner: Burhan Khalid => Baptiste Mispelon
* needs_better_patch: 1 => 0
Comment:
I took Burhan Khalid's pull request and updated it to target the 3.1
release.
I also tweaked the regexp for the accepted schemes to better match the RFC
(I think).
As suggested by Tim in the previous pull request, I added a test to make
sure all currently assigned schemes [1] are validated by the regexp.
[https://github.com/django/django/pull/12171 PR here]
[1] https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:8>
Django
Reporter: Tim Graham | Owner: Baptiste
| Mispelon
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
As I commented on the PR, I'm not 100% convinced we shouldn't be saying
that folks should create a custom validator for the known set of schemes
that they want to accept, rather than adding an `'__all__'`. What do
others think?
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:9>
Django
Reporter: Tim Graham | Owner: Baptiste
| Mispelon
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* status: assigned => closed
* resolution: => wontfix
Comment:
Agreed, I don't see a wide usage of `__all__`. In most of cases you want
to add some schemas which is
[https://docs.djangoproject.com/en/3.0/ref/validators/#django.core.validators.URLValidator.schemes
already possible]. I believe solving #25594 would be a real solution for
easy customizing the list of schemes.
--
Ticket URL: <https://code.djangoproject.com/ticket/26424#comment:10>