[Django] #25688: admin.register shouldn't allow an empty list of models to be registered
Django
------------------------------------------------+------------------------
Reporter: bmispelon | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
I couldn't remember how to do the model registering using the decorator
syntax and ended up with this code:
{{{#!python
@admin.register()
class MyModelAdmin(admin.ModelAdmin):
pass
}}}
This code doesn't actually do anything, but it does so silently. I think
`register` should complain when you give it no actual model to register.
--
Ticket URL: <https://code.djangoproject.com/ticket/25688>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: bmispelon | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by charettes):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/25688#comment:1>
Django
Reporter: bmispelon | Owner: hramezani
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by hramezani):
* owner: nobody => hramezani
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/25688#comment:2>
Django
Reporter: bmispelon | Owner: hramezani
Type: | Status: assigned
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by hramezani):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/5563 Pull Request]
--
Ticket URL: <https://code.djangoproject.com/ticket/25688#comment:3>
Django
Reporter: bmispelon | Owner: hramezani
Type: | Status: assigned
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by claudep):
* version: 1.8 => master
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/25688#comment:4>
Django
Reporter: bmispelon | Owner: hramezani
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by aaronelliotross):
* Attachment "empty_list_fails_to_register.diff" added.
Adds a test and applies requested fixes to comments.
Django
Reporter: bmispelon | Owner: hramezani
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by aaronelliotross):
* cc: aaronelliotross@… (added)
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/25688#comment:5>
Django
Reporter: bmispelon | Owner: hramezani
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25688#comment:6>
Django
Reporter: bmispelon | Owner: hramezani
Cleanup/optimization |
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"8c553e7d3fd3f598a445f3c35711829e9b3645a4" 8c553e7d]:
{{{
#!CommitTicketReference repository=""
revision="8c553e7d3fd3f598a445f3c35711829e9b3645a4"
Fixed #25688 -- Made admin.register() disallow an empty list of models.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25688#comment:7>