[Django] #26089: The auth custom test model tables are not created anymore.
Django
-------------------------------------------+---------------------------
Reporter: charettes | Owner: charettes
Type: Bug | Status: new
Component: contrib.auth | Version: 1.8
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+---------------------------
Since the introduction of contrib application migrations in 1.8 (#22170)
the [https://docs.djangoproject.com/en/1.9/topics/auth/customizing
/#custom-users-and-testing-fixtures documented custom user test models]
table are not created anymore because they are registered to the `'auth'`
labeled application but are not part of its shipped migrations.
Based on the fact this was not reported before and that the only uses of
`ExtensionUser` I can find is
[https://github.com/search?l=python&q=django+ExtensionUser&ref=searchresults&type=Code&utf8=%E2%9C%93
either from a vendored version of Django or a copy-pasta of the
documentation suggested usage] I think we can safely assume it's not
commonly used among third-party application who claim to support custom
user models. I'll make sure to post the mailing list in order to gather
feedback from the community about this point.
Given the models are simply not usable on 1.8 and 1.9 now I'd like to
start the deprecation in 1.8 in order order to be able to completely
remove them on master but if it's not considered safe enough I came up
with a with a workaround that could be backported since there's still no
documented way to ship test only models (#7835).
If these models are relied on by the community I would suggest we start
deprecating them in 1.10 and adjust the documentation to suggest
subclassing the provided abstract models instead.
--
Ticket URL: <https://code.djangoproject.com/ticket/26089>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: charettes | Owner: charettes
Type: Bug | Status: new
Component: contrib.auth | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
I've [https://groups.google.com/d/topic/django-
developers/q0LE90DtxIc/discussion written to django-developers] with my
take on it.
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:1>
Django
Reporter: charettes | Owner: charettes
Type: Bug | Status: new
Component: contrib.auth | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* severity: Release blocker => Normal
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:2>
Django
Reporter: charettes | Owner: charettes
Type: Bug | Status: new
Component: contrib.auth | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
Comment:
My [https://github.com/django/django/pull/6024 PR] for documentation
removal of the broken models (to be backported to 1.8).
Simon's [https://github.com/django/django/pull/5975 PR] for removing the
models from the public API.
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:3>
Django
Reporter: charettes | Owner: charettes
Type: Bug | Status: new
Component: contrib.auth | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"1e9150443e5696d764ed81c97b53ef0365a5d854" 1e915044]:
{{{
#!CommitTicketReference repository=""
revision="1e9150443e5696d764ed81c97b53ef0365a5d854"
Refs #26089 -- Removed obsolete docs about custom user model testing.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:4>
Django
Reporter: charettes | Owner: charettes
Type: Bug | Status: new
Component: contrib.auth | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"194bf8ca621064daceb9b801df68ce6ae906936a" 194bf8c]:
{{{
#!CommitTicketReference repository=""
revision="194bf8ca621064daceb9b801df68ce6ae906936a"
[1.9.x] Refs #26089 -- Removed obsolete docs about custom user model
testing.
Backport of 1e9150443e5696d764ed81c97b53ef0365a5d854 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:6>
Django
Reporter: charettes | Owner: charettes
Type: Bug | Status: new
Component: contrib.auth | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"ea2d9f0d4a920606c105c9a7f2131327473204c7" ea2d9f0]:
{{{
#!CommitTicketReference repository=""
revision="ea2d9f0d4a920606c105c9a7f2131327473204c7"
[1.8.x] Refs #26089 -- Removed obsolete docs about custom user model
testing.
Backport of 1e9150443e5696d764ed81c97b53ef0365a5d854 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:5>
Django
Reporter: charettes | Owner: charettes
Type: Bug | Status: new
Component: contrib.auth | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_docs: 0 => 1
Comment:
[https://github.com/django/django/pull/5975 PR] needs a mention in the
1.10 release notes just be on the safe side.
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:7>
Django
Reporter: charettes | Owner: charettes
Type: Bug | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* status: new => assigned
* needs_docs: 1 => 0
* version: 1.8 => master
Comment:
Here's the [https://github.com/django/django/pull/6086 PR] with release
notes.
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:8>
Django
Reporter: charettes | Owner: charettes
Type: Bug | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:9>
Django
Django 1.8)
-------------------------------------+-------------------------------------
Reporter: charettes | Owner: charettes
Type: Bug | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:10>
Django
Django 1.8)
-------------------------------------+-------------------------------------
Type: Bug | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Simon Charette <charette.s@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"6eb3ce11e4d6be237ad2e4895d8ae0b7bc1803dc" 6eb3ce11]:
{{{
#!CommitTicketReference repository=""
revision="6eb3ce11e4d6be237ad2e4895d8ae0b7bc1803dc"
Fixed #26089 -- Removed custom user test models from public API.
Thanks to Tim Graham for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26089#comment:11>