[Django] #26938: Template postmortem on debug page contains invalid HTML

14 views
Skip to first unread message

Django

unread,
Jul 22, 2016, 8:34:55 PM7/22/16
to django-...@googlegroups.com
#26938: Template postmortem on debug page contains invalid HTML
---------------------------------+-----------------
Reporter: jdufresne | Owner:
Type: Bug | Status: new
Component: Error reporting | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-----------------
There is an extra `</ul>` in the template:

https://github.com/django/django/blob/32cf01c1c1dcd5fa5d700d0e5117778caf947b74/django/views/debug.py#L729

This bug was introduced in 1.9, commit
[https://github.com/django/django/commit/65a7a0d9eed4f4da9568cf0e7688e7a8c9f01957
65a7a0d9eed4f4da9568cf0e7688e7a8c9f01957].

I would appreciate if the fix would be considered for the next 1.9 bug fix
release. I use a middleware for HTML validation. After upgrading from 1.8,
this middleware is now reporting some 500 pages as invalid instead of
showing me the useful information. This was not the case with 1.8.

--
Ticket URL: <https://code.djangoproject.com/ticket/26938>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 22, 2016, 9:37:03 PM7/22/16
to django-...@googlegroups.com
#26938: Template postmortem on debug page contains invalid HTML
---------------------------------+--------------------------------------

Reporter: jdufresne | Owner:
Type: Bug | Status: new
Component: Error reporting | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by jdufresne):

* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_docs: => 0


Comment:

[https://github.com/django/django/pull/6966 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/26938#comment:1>

Django

unread,
Jul 23, 2016, 6:26:04 AM7/23/16
to django-...@googlegroups.com
#26938: Template postmortem on debug page contains invalid HTML
---------------------------------+------------------------------------

Reporter: jdufresne | Owner:
Type: Bug | Status: new
Component: Error reporting | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by claudep):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/26938#comment:2>

Django

unread,
Jul 24, 2016, 12:20:31 PM7/24/16
to django-...@googlegroups.com
#26938: Template postmortem on debug page contains invalid HTML
-------------------------------------+-------------------------------------

Reporter: jdufresne | Owner:
Type: Bug | Status: new
Component: Error reporting | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by MarkusH):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/26938#comment:3>

Django

unread,
Jul 24, 2016, 12:22:37 PM7/24/16
to django-...@googlegroups.com
#26938: Template postmortem on debug page contains invalid HTML
-------------------------------------+-------------------------------------
Reporter: jdufresne | Owner: Markus
| Holtermann <info@…>
Type: Bug | Status: closed

Component: Error reporting | Version: 1.9
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Markus Holtermann <info@…>):

* status: new => closed
* owner: => Markus Holtermann <info@…>
* resolution: => fixed


Comment:

In [changeset:"348cfccd9072f0e08ffe4cfb3946d1dc6a629e86" 348cfccd]:
{{{
#!CommitTicketReference repository=""
revision="348cfccd9072f0e08ffe4cfb3946d1dc6a629e86"
Fixed #26938 -- Fixed invalid HTML in template postmortem on the debug
page.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26938#comment:4>

Django

unread,
Jul 24, 2016, 12:27:34 PM7/24/16
to django-...@googlegroups.com
#26938: Template postmortem on debug page contains invalid HTML
-------------------------------------+-------------------------------------
Reporter: jdufresne | Owner: Markus
| Holtermann <info@…>
Type: Bug | Status: closed
Component: Error reporting | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Markus Holtermann <info@…>):

In [changeset:"c0026a9d2dc2cdf4da583845fc1d9ae8402a984c" c0026a9]:
{{{
#!CommitTicketReference repository=""
revision="c0026a9d2dc2cdf4da583845fc1d9ae8402a984c"
[1.10.x] Fixed #26938 -- Fixed invalid HTML in template postmortem on the
debug page.

Backport of 348cfccd9072f0e08ffe4cfb3946d1dc6a629e86 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26938#comment:5>

Django

unread,
Jul 24, 2016, 12:30:07 PM7/24/16
to django-...@googlegroups.com
#26938: Template postmortem on debug page contains invalid HTML
-------------------------------------+-------------------------------------
Reporter: jdufresne | Owner: Markus
| Holtermann <info@…>
Type: Bug | Status: closed
Component: Error reporting | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Markus Holtermann <info@…>):

In [changeset:"caec27f87c56442d4512cb6dd9e6c26fd8d4414a" caec27f]:
{{{
#!CommitTicketReference repository=""
revision="caec27f87c56442d4512cb6dd9e6c26fd8d4414a"
[1.9.x] Fixed #26938 -- Fixed invalid HTML in template postmortem on the
debug page.

Backport of 348cfccd9072f0e08ffe4cfb3946d1dc6a629e86 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26938#comment:6>

Reply all
Reply to author
Forward
0 new messages