[Django] #33407: Radiolist etc. styling has changed since it's using div elements not ul elements
Django
elements
-----------------------------------------------+------------------------
Reporter: Matthias Kestenholz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------------+------------------------
The `ul.radiolist` styles
(https://github.com/django/django/blob/0ab58c120939093fea90822f376e1866fc714d1f/django/contrib/admin/static/admin/css/forms.css#L40)
aren't applied anymore since
https://github.com/django/django/commit/5942ab5eb165ee2e759174e297148a40dd855920
Django 3.2:
[[Image(https://user-
images.githubusercontent.com/2627/147959940-4fa1ed20-6c23-41b5-9822-04c6c9433717.jpg)]]
Django 4.0:
[[Image(https://user-
images.githubusercontent.com/2627/147959938-09344430-3c49-486a-b69e-
233820260b46.jpg)]]
--
Ticket URL: <https://code.djangoproject.com/ticket/33407>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
elements
Reporter: Matthias Kestenholz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* cc: David Smith (added)
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
Comment:
Thanks for the report, good catch! We should update CSS styles and rename
`django.contrib.admin.options.get_ul_class()` hook (this can be done as a
cleanup on the `main` branch).
Regression in 5942ab5eb165ee2e759174e297148a40dd855920.
--
Ticket URL: <https://code.djangoproject.com/ticket/33407#comment:1>
Django
elements
Reporter: Matthias Kestenholz | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mohamed Nabil Rady):
* owner: nobody => Mohamed Nabil Rady
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/33407#comment:2>
Django
elements
Reporter: Matthias Kestenholz | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* needs_docs: 0 => 1
Comment:
[https://github.com/django/django/pull/15283 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33407#comment:3>
Django
elements
Reporter: Matthias Kestenholz | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* owner: Mohamed Nabil Rady => Carlton Gibson
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
Comment:
[https://github.com/django/django/pull/15333 Alternate PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33407#comment:4>
Django
elements
Reporter: Matthias Kestenholz | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33407#comment:5>
Django
elements
Reporter: Matthias Kestenholz | Owner: Carlton
| Gibson
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson <carlton.gibson@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"85f2a9fb0f0973930abc84a725bc30703aa3d98b" 85f2a9fb]:
{{{
#!CommitTicketReference repository=""
revision="85f2a9fb0f0973930abc84a725bc30703aa3d98b"
Fixed #33407 -- Fixed .radiolist admin CSS.
Regression in 5942ab5eb165ee2e759174e297148a40dd855920.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33407#comment:6>
Django
elements
Reporter: Matthias Kestenholz | Owner: Carlton
| Gibson
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"f82ca84f775f534b32e6ffcef6baa75da6bec47b" f82ca84]:
{{{
#!CommitTicketReference repository=""
revision="f82ca84f775f534b32e6ffcef6baa75da6bec47b"
[4.0.x] Fixed #33407 -- Fixed .radiolist admin CSS.
Regression in 5942ab5eb165ee2e759174e297148a40dd855920.
Backport of 85f2a9fb0f0973930abc84a725bc30703aa3d98b from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33407#comment:7>