[Django] #27679: Formsets: min_num and extra
Django
-----------------------------------------+------------------------
Reporter: Lorenzo Peña | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
I already read #22628
To me: min_num is an option for validation and extra is an option for
presentation
Currently, in an empty formset, you get min_num+extra empty forms, I think
it should be max(min_num, extra) instead
--
Ticket URL: <https://code.djangoproject.com/ticket/27679>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: Lorenzo Peña | Owner: nobody
Cleanup/optimization |
Component: Forms | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* type: Uncategorized => Cleanup/optimization
* component: Uncategorized => Forms
Comment:
You should say a little more to strengthen your proposal. For example,
what are the ramifications for backwards compatibility? What does the
documentation say about this?
--
Ticket URL: <https://code.djangoproject.com/ticket/27679#comment:1>
Django
--------------------------------------+------------------------------------
Reporter: Lorenzo Peña | Owner: nobody
Component: Documentation | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* component: Forms => Documentation
* stage: Unreviewed => Accepted
Comment:
Looks like this was [https://github.com/django/django/pull/2655#r12731342
considered previously] and rejected due to backwards compatibility.
Tentatively accepting as a documentation enhancement pending no further
arguments to change the behavior.
--
Ticket URL: <https://code.djangoproject.com/ticket/27679#comment:2>
Django
Reporter: Lorenzo Peña | Owner: David
Type: | Smith
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by David Smith):
* owner: nobody => David Smith
* status: new => assigned
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27679#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Lorenzo Peña | Owner: David
Type: | Smith
Component: Documentation | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"e2e34f4de3b90f3820ee11d49cc369ef573bc2ef" e2e34f4d]:
{{{
#!CommitTicketReference repository=""
revision="e2e34f4de3b90f3820ee11d49cc369ef573bc2ef"
Fixed #27679 -- Doc'd that empty formsets display extra + min_num forms.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27679#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Lorenzo Peña | Owner: David
Type: | Smith
Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"b2fc5292b23cd6689063c3ff97eaa802400d8b8a" b2fc5292]:
{{{
#!CommitTicketReference repository=""
revision="b2fc5292b23cd6689063c3ff97eaa802400d8b8a"
[3.1.x] Fixed #27679 -- Doc'd that empty formsets display extra + min_num
forms.
Backport of e2e34f4de3b90f3820ee11d49cc369ef573bc2ef from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27679#comment:5>