Re: [Django] #13956: Indefinite args for simpletags and inclusion tags
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by patchhammer):
* needs_better_patch: 0 => 1
* easy: => 0
Comment:
patch_r15283.diff fails to apply cleanly on to trunk
--
Ticket URL: <http://code.djangoproject.com/ticket/13956#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
-------------------------------------+-------------------------------------
Changes (by melinath):
* needs_better_patch: 1 => 0
Comment:
Updated the patch to r16322. Applies cleanly with no unexpected test
failures.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by julien):
* needs_better_patch: 0 => 1
* ui_ux: => 0
* needs_docs: 0 => 1
Comment:
Thank you, the patch looks pretty good! For consistency, could the same be
done for `@assignment_tag`? The documentation also needs to be updated.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
* needs_tests: 0 => 1
Comment:
I added varargs support to the assignment tag, but I still need to add
tests for it. Also, I rearranged things a little, which could cause
backwards incompatibility with anyone using internals extremely heavily.
It's not necessary and I could revert that bit if people think it will
cause serious problems.
What exactly needs to be documented? For me, this is the expected
behavior.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
From what I see in the patch I don't think backwards incompatibility would
be an issue, especially as this is really low level internal stuff. Can
you think of specific ways where that would be an issue?
For the doc, a short notice in each section for include_tag, simple_tag
and assignment_tag saying that those tags can have an indefinite number of
arguments would suffice. It's also worth mentioning this new feature in
the release notes.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by melinath):
Specifically, the patch in its current state changes the signature of
generic_tag_compiler from (params, defaults, name, node_class, parser,
token) to (parser, token, params, defaults, name, node_class, varargs) for
no reason other than that I think it reads better to have parser and token
first, since that's standard for tag compilation functions anyway. If
anyone were using generic_tag_compiler and counting on the order of the
arguments, this patch would break it.
I'll add the tests, docs and release notes to the patch soonish. (Unless
someone beats me to it.)
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
OK, so if it's purely for cosmetic reasons, let's just leave it the way it
was. I don't think the change would affect many people but it's not really
worth taking any risk here.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:15>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by melinath):
On the other hand, "beautiful is better than ugly". If I really want to
maintain backwards-compatibility, I need to make the additional argument
optional. Comparison:
1. Original signature: `(params, defaults, name, node_class, parser,
token)`
2. New signature: `(parser, token, params, defaults, name, node_class,
varargs)`
3. Alternate: `(params, defaults, name, node_class, varargs, parser,
token)`
4. Backwards-compatible signature: `(params, defaults, name, node_class,
parser, token, varargs=None)`
4 is taking a turn down an inelegant path. I really would rather do 2 or
3.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:16>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by melinath):
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* needs_docs: 1 => 0
Comment:
This patch should address all concerns. Has docs and release notes. Has
tests for everything - now modeled after and together with the other
simple, inclusion, and assignment tests instead of elsewhere. Uses the
backwards-compatible signature.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:17>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by melinath):
Incidentally, passes with no unexpected failures.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:18>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
checkin | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by julien):
* stage: Accepted => Ready for checkin
Comment:
That looks great, thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:19>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Ready for | Has patch: 1
checkin | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by jezdez):
While I appreciate the effort of this ticket I'd like to voice my concern
that adding support for `*args` but not `**kwargs` might not be the wisest
decision with regard to compatibility. We now have a good standard for
kwargs in template tags (due to the with/include tag refactor by
!SmileyChris) and shouldn't ignore this when extending the helper tags.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:20>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Patch needs improvement: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by julien):
* stage: Ready for checkin => Accepted
Comment:
Sorry, after discussing with jezdez on IRC, we're going to hold off for
the moment. The idea is to investigate whether support for `**kwargs`
should also be added at the same time, while we're at it. Any insight on
the implementation details for that would be useful.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:21>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by jezdez):
Thanks Julien, much appreciated. I wrote to the -developers list about it,
too.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:22>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by SamBull):
I built a utility app called fancy_tag that addresses this issue. It's a
drop-in replacement for simple_tag that adds support for *args, keyword
args, **kwargs. It also adds support for the "with <varname>" pattern. The
app comes with unit tests and the whole thing shouldn't be too hard to
convert into a patch.
You can check it out here: https://github.com/trapeze/fancy_tag
Let me know if you'd like me to submit this as a patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:23>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: gregmuellegger
Type: New | Status: assigned
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
* cc: cg@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:24>
Django
-------------------------------------+-------------------------------------
Type: New | Status: new
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
decision needed | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by melinath):
* owner: gregmuellegger => melinath
* status: assigned => new
* stage: Accepted => Design decision needed
Comment:
Reassigning to myself after asking gregmuelleger. Also setting to DDN
since that seems to be the case. [http://groups.google.com/group/django-
developers/browse_thread/thread/b00fbb49f10e9854 See the discussion in the
developer's list.]
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:25>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: melinath
Type: New | Status: new
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Design | Has patch: 1
decision needed | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
* cc: osirius@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:26>
Django
-------------------------------------+-------------------------------------
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by julien):
* owner: melinath => julien
* stage: Design decision needed => Accepted
Comment:
I'm working on this.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:27>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Type: New | Status: new
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
OK, so I think this is ready for review. I've got some inspiration from
SamBull's `fancy_tag`, although the implementation here is a bit cleaner
and a bit more robust. It's quite thoroughly tested. I still need to write
some documentation. Any feedback welcome, thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:28>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Type: New | Status: new
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
Oh, I should have clarified that with the proposed patch `inclusion_tag`,
`simple_tag` and `assignment_tag` now have full `*args` and `**kwargs`
support, working the same way as in Python.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:29>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Type: New | Status: new
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by jezdez):
* stage: Accepted => Ready for checkin
Comment:
LGTM, thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:30>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Type: New | Status: new
feature | Component: Template system
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
Resolution: | simpletag
Triage Stage: Ready for | Has patch: 1
checkin | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
Thanks a lot for the review and PEP8 cleanup, Jannis! I'll write a bit of
documentation before pushing it in.
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:31>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Milestone: | Severity: Normal
Version: SVN | Keywords: simple_tag,
checkin | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [16908]:
{{{
#!CommitTicketReference repository="" revision="16908"
Fixed #13956 -- Enabled `*args` and `**kwargs` support for `simple_tag`,
`inclusion_tag` and `assignment_tag`. Many thanks to Stephen Burrows for
the report and initial patch, to Gregor Müllegger for the initial tests,
to SamBull for the suggestions, and to Jannis Leidel for the review and
PEP8 cleanup.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:32>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Component: Template system | Version: SVN
Severity: Normal | Resolution: fixed
Keywords: simple_tag, | Triage Stage: Ready for
simpletag | checkin
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by loewis):
In [16950]:
{{{
#!CommitTicketReference repository="" revision="16950"
Merged revisions
16743,16745,16747-16750,16752-16754,16756-16760,16770,16773-16800,16802-16804,16806,16808,16811,16813,16815,16817-16826,16829-16833,16835-16836,16838-16843,16845-16858,16860-16866,16868,16871-16877,16882-16890,16893-16947
via svnmerge from
https://code.djangoproject.com/svn/django/trunk
........
r16743 | gabrielhurley | 2011-09-09 23:36:58 +0200 (Fr, 09 Sep 2011) | 2
lines
Fixed #16791 -- Updated a broken URL in the README file. Thanks to
paulcwatts for the report and patch.
........
r16745 | Alex | 2011-09-09 23:45:58 +0200 (Fr, 09 Sep 2011) | 1 line
Switch to using explicit new-style division behavior, rather than
relying on teh classic behavior.
........
r16747 | SmileyChris | 2011-09-10 00:32:38 +0200 (Sa, 10 Sep 2011) | 1
line
Fix and test for cleaning a non-string value in a URLField
........
r16748 | gabrielhurley | 2011-09-10 00:33:28 +0200 (Sa, 10 Sep 2011) | 2
lines
Fixed #16786 -- Minor cleanups in the memcached section of the caching
topic guide. Thanks to jamesp for the report and patch.
........
r16749 | jbronn | 2011-09-10 00:34:23 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16408 -- Fixed conversion of dates, and other problems with the
SpatiaLite backend.
........
r16750 | jbronn | 2011-09-10 00:47:18 +0200 (Sa, 10 Sep 2011) | 1 line
Removed extra call to `syncdb` that slipped in with r16749.
........
r16752 | SmileyChris | 2011-09-10 00:57:12 +0200 (Sa, 10 Sep 2011) | 1
line
Fixes #16664 -- URLField's to_python method fails with ValueError on
some urls on python 2.7. Based on patch by zigzag.
........
r16753 | russellm | 2011-09-10 01:02:33 +0200 (Sa, 10 Sep 2011) | 1 line
Added two pointless query repeats to work around a known issue with
MySQL that was causing failures in our test suite.
........
r16754 | gabrielhurley | 2011-09-10 01:25:48 +0200 (Sa, 10 Sep 2011) | 2
lines
Fixed #16782 -- Corrected a broken cross-reference to the database
engine setting in the tutorial. Thanks to mjumbewu for the report and
patch.
........
r16756 | kmtracey | 2011-09-10 02:05:48 +0200 (Sa, 10 Sep 2011) | 2
lines
Fixed #15722: ensure formsets evaluate to True even if they have no
forms. Thanks mlavin.
........
r16757 | jbronn | 2011-09-10 02:29:34 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #13670 -- Comparisons with the spatial adapter won't blow up in
some corner cases. Thanks, milosu for the bug report and jpaulett for the
patch.
........
r16758 | russellm | 2011-09-10 02:46:38 +0200 (Sa, 10 Sep 2011) | 1 line
Added protection against spoofing of X_FORWARDED_HOST headers. A
security announcement will be made shortly.
........
r16759 | russellm | 2011-09-10 02:46:48 +0200 (Sa, 10 Sep 2011) | 1 line
Corrected an issue which could allow attackers to manipulate session
data using the cache. A security announcement will be made shortly.
........
r16760 | russellm | 2011-09-10 02:47:00 +0200 (Sa, 10 Sep 2011) | 1 line
Altered the behavior of URLField to avoid a potential DOS vector, and to
avoid potential leakage of local filesystem data. A security announcement
will be made shortly.
........
r16770 | Alex | 2011-09-10 03:53:56 +0200 (Sa, 10 Sep 2011) | 1 line
Make ``Formset.__getitem__`` O(1), rather than O(n). If you override
``__iter__`` you now need to also override ``__getitem__`` for consistant
behavior. Thanks to Carl and Russ for the review.
........
r16773 | Alex | 2011-09-10 04:42:05 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #11404. Added ``FormSet.has_changed``, for consistancy with
``Form.has_changed``. Thanks to michelts for the patch.
........
r16774 | Alex | 2011-09-10 04:52:37 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16793. Added more cross referencing to the load tag's
documentation. Thanks to bluejeansummer for the patch.
........
r16775 | jbronn | 2011-09-10 05:04:30 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16790 -- Modified the geographic admin to work after r16594.
Thanks, jdiego, for the bug report and patch.
........
r16776 | carljm | 2011-09-10 05:26:13 +0200 (Sa, 10 Sep 2011) | 1 line
Corrected documentation inconsistencies regarding deprecation of
URLField.verify_exists.
........
r16777 | carljm | 2011-09-10 05:33:54 +0200 (Sa, 10 Sep 2011) | 1 line
Added basic release notes for 1.2.6 and 1.3.1.
........
r16778 | Alex | 2011-09-10 19:09:23 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16162. Added timeout arg to `DummyCache.set_many`, for
compatiblity with other caches. Thanks to aaugustin for the patch.
........
r16779 | jbronn | 2011-09-10 19:19:05 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16537 -- Fixed multi-db issues with GeoDjango utilities. Thanks,
Shane Shifflett for the bug report and aaugustin for the initial patch.
........
r16780 | Alex | 2011-09-10 19:20:31 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16280. Document that both args and kwargs cannot be passed to
reverse at the same time.
........
r16781 | russellm | 2011-09-10 19:29:33 +0200 (Sa, 10 Sep 2011) | 1 line
Refs #16490 - Add a commit to ensure that a fresh read is provided; this
is only a problem for databases in REPEATABLE READ mode, which is MySQL
InnoDB's default. Thanks to Jim Dalton for the report and patch.
........
r16782 | Alex | 2011-09-10 19:38:58 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16808, removed some dead code from teh ORM. Thanks to aaugustin
for the patch.
........
r16783 | jbronn | 2011-09-10 20:04:27 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16553 -- Refactored the `GeoIP` module, moving it
`django.contrib.gis.geoip`; fixed memory leaks, and encoding issues.
........
r16784 | russellm | 2011-09-10 20:44:33 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16490 -- Skipped a test failure that only occurs under Python
2.6.1 (it's the old iteration-eats-exceptions problem).
........
r16785 | russellm | 2011-09-10 20:58:30 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16809 -- Forced MySQL to behave like a database. This avoids a
problem where queries that do IS NONE checks can return the wrong result
the first time they are executed if there is a recently inserted row.
Thanks to James Pyrich for the debug work and patch.
........
r16786 | Alex | 2011-09-10 21:45:16 +0200 (Sa, 10 Sep 2011) | 1 line
Make a comment more accurate.
........
r16787 | russellm | 2011-09-10 22:06:10 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16592 -- More test changes and documentation to account for
MySQL's casual relationship with sanity. Thanks to Jim Dalton for the
report and patch.
........
r16788 | Alex | 2011-09-10 23:00:25 +0200 (Sa, 10 Sep 2011) | 1 line
Remove this deprecated alias.
........
r16789 | Alex | 2011-09-10 23:00:32 +0200 (Sa, 10 Sep 2011) | 1 line
Removed the deprecated-since-1.2 "supports_object_permissions" and
"supports_anonymous_user" flags on authentication backends. If you have
an authenication backend it now *must* suport these.
........
r16790 | Alex | 2011-09-10 23:29:21 +0200 (Sa, 10 Sep 2011) | 1 line
Fixed #16810, corrected a bad docstring. Thanks to kenkam for the patch.
........
r16791 | Alex | 2011-09-10 23:44:57 +0200 (Sa, 10 Sep 2011) | 1 line
Ensure bulk_create returns what it is supposed to.
........
r16792 | Alex | 2011-09-10 23:46:59 +0200 (Sa, 10 Sep 2011) | 1 line
Ensure bulk_create returns the right value if the argument is an empty
list.
........
r16793 | Alex | 2011-09-11 00:02:13 +0200 (So, 11 Sep 2011) | 1 line
Fixed bulk_insertion on databases which don't yet support it. Thanks to
Justin Bronn for his Oracle wizardry.
........
r16794 | Alex | 2011-09-11 00:31:38 +0200 (So, 11 Sep 2011) | 1 line
Remove a bunch of deadcode/dead imports.
........
r16795 | Alex | 2011-09-11 00:46:44 +0200 (So, 11 Sep 2011) | 1 line
Kill some more dead code.
........
r16796 | jbronn | 2011-09-11 00:53:26 +0200 (So, 11 Sep 2011) | 1 line
Fixed #14648 -- Fixed annotated date querysets when `GeoManager` is
used. Thanks, codysoyland, for the bug report.
........
r16797 | jbronn | 2011-09-11 02:00:15 +0200 (So, 11 Sep 2011) | 1 line
Fixed #15305 -- Made `Count` aggregate and `.values()` play nice
together on `GeoQuerySets`. Thanks, vrehak for the bug report and milosu
for initial patch.
........
r16798 | jbronn | 2011-09-11 02:15:43 +0200 (So, 11 Sep 2011) | 1 line
Fixed #13429 -- Changed `WorldBorders` to just `WorldBorder` in
GeoDjango tutorial. Thanks, tubaman for the bug report.
........
r16799 | ramiro | 2011-09-11 02:52:03 +0200 (So, 11 Sep 2011) | 4 lines
Fixed #14138 -- Removed a superfluous import in the sqlite3 DB backend.
This could be of help with some issues people were seeing when deploying
Django with sqlite and Apache.
........
r16800 | jbronn | 2011-09-11 02:52:08 +0200 (So, 11 Sep 2011) | 1 line
Fixed #16231 -- Added support for GML and KML on the SpatiaLite backend.
Thanks, steko for the bug report and jpaulett for the patch.
........
r16802 | julien | 2011-09-11 03:12:11 +0200 (So, 11 Sep 2011) | 1 line
Fixed #16276 -- Noted in the deployment documentation index that the
Django Book 2nd ed. was written against Django 1.1. Thanks to bshaurette
and bluejeansummer for the patch.
........
r16803 | carljm | 2011-09-11 04:28:08 +0200 (So, 11 Sep 2011) | 1 line
Added basic release notes for 1.2.7.
........
r16804 | ubernostrum | 2011-09-11 06:01:41 +0200 (So, 11 Sep 2011) | 1
line
Fixed #16079: Clarified (for real this time) how handler404 and
handler500 work, and that they only work in a root URLconf.
........
r16806 | ubernostrum | 2011-09-11 07:31:00 +0200 (So, 11 Sep 2011) | 1
line
Fixed #16552: Noted that contrib.sessions is a requirement for the
admin.
........
r16808 | ubernostrum | 2011-09-11 07:37:55 +0200 (So, 11 Sep 2011) | 1
line
Fixed #16293: Document a way to return dicts with column names from a DB
cursor.
........
r16811 | ubernostrum | 2011-09-11 07:44:21 +0200 (So, 11 Sep 2011) | 1
line
Fixed #16109: Corrected an inconsistency in URLconf examples for
matching a numeric month.
........
r16813 | ubernostrum | 2011-09-11 07:47:48 +0200 (So, 11 Sep 2011) | 1
line
Fixed #16094: Added clear example of how to refer to custom permissions.
........
r16815 | ubernostrum | 2011-09-11 07:57:38 +0200 (So, 11 Sep 2011) | 1
line
Fixed #16334: Make it quite clear that cache_page's 'cache' argument
refers to the name of a cache in the CACHES setting.
........
r16817 | julien | 2011-09-11 21:28:18 +0200 (So, 11 Sep 2011) | 1 line
Fixed #16742 -- Provided code examples in the models documentation for
accessing extra fields on many-to-many relationships. Many thanks to aj
for the suggestion and to Nick Lang for the patch.
........
r16818 | ramiro | 2011-09-12 00:36:16 +0200 (Mo, 12 Sep 2011) | 9 lines
Fixed #14675 -- Completed removal of `from django.conf.urls.default
import *` usage.
This applies to both our own [test] code and documentation examples.
Also:
* Moved the functions and handlers from `django.conf.urls.defaults` up
to
`django.conf.urls` deprecating the former module.
* Added documentation for `handler403`.
* Tweaked the URLs topic document a bit.
Thanks to pupeno and cdestigter for their great work contributing
patches.
........
r16819 | ramiro | 2011-09-12 01:02:53 +0200 (Mo, 12 Sep 2011) | 3 lines
Added an implementation of bulk insert via the ORM to the Oracle DB
backend.
Refs #7596, r16739 and http://troels.arvin.dk/db/rdbms/#insert-multiple
........
r16820 | julien | 2011-09-12 09:12:28 +0200 (Mo, 12 Sep 2011) | 1 line
Fixed #16291 -- Documented that TypedChoiceField does not coerce
empty_value. Thanks to vanschelven and taavi223.
........
r16821 | julien | 2011-09-12 09:15:47 +0200 (Mo, 12 Sep 2011) | 1 line
Fixed some improper quotes in the form fields reference doc.
........
r16822 | julien | 2011-09-13 05:10:07 +0200 (Di, 13 Sep 2011) | 1 line
Fixed #4198 -- Fixed a small styling issue in the admin calendar widget.
Thanks to Gary Wilson and fcurella.
........
r16823 | julien | 2011-09-13 10:22:53 +0200 (Di, 13 Sep 2011) | 1 line
Fixed #16815 -- Rectified the code example for hidden_fields and
visible_fields in the forms documentation. Thanks, joonas.
........
r16824 | jezdez | 2011-09-13 17:10:49 +0200 (Di, 13 Sep 2011) | 1 line
Fixed #16833 -- Removed undocumented `mixin` parameter from the
`Storage.open()` method as this was an undocumented and obscure feature.
Thanks to Marty and Russell for sanity-checking.
........
r16825 | jbronn | 2011-09-13 22:30:24 +0200 (Di, 13 Sep 2011) | 1 line
Updated versions and added `libproj-dev` to the GeoDjango installation
docs.
........
r16826 | jbronn | 2011-09-13 22:43:33 +0200 (Di, 13 Sep 2011) | 1 line
Fixed #16778 -- Improved escaping of geometries on PostgreSQL, allowing
GeoDjango to work on 9.1. Thanks, piro for ticket and patch.
........
r16829 | PaulM | 2011-09-15 01:27:35 +0200 (Do, 15 Sep 2011) | 2 lines
Fixed #16494 by normalizing HttpResponse behavior with non-string input.
HttpResponse now always converts content to string on output, regardless
of input type.
........
r16830 | PaulM | 2011-09-15 01:58:12 +0200 (Do, 15 Sep 2011) | 2 lines
Slight cleanup to r16829, thanks Alex Gaynor for the note.
........
r16831 | carljm | 2011-09-15 09:26:35 +0200 (Do, 15 Sep 2011) | 6 lines
Fixed #16848 - Adjusted SimpleTemplateResponse.__init__ to be less
brittle.
Could have reverted r16830 instead, but HttpResponse shouldn't have to
dance
around and do non-obvious things to keep TemplateResponse happy,
TemplateResponse should be robust against the possibility that
HttpResponse.__init__ might set self.content.
........
r16832 | Alex | 2011-09-16 01:55:30 +0200 (Fr, 16 Sep 2011) | 1 line
Fixed #16854 -- corrected an AttributeError coming from the contenttypes
post-syncdb hook. Thanks to desh for the report.
........
r16833 | carljm | 2011-09-16 03:16:25 +0200 (Fr, 16 Sep 2011) | 9 lines
Fixed #16770 -- Eliminated TemplateSyntaxError wrapping of exceptions.
Thanks to Justin Myles-Holmes for report and draft patch.
Exceptions raised in templates were previously wrapped in
TemplateSyntaxError
(in TEMPLATE_DEBUG mode only) in order to provide template source
details on
the debug 500 page. The same debug information is now provided by
annotating
exceptions rather than wrapping them. This makes catching exceptions
raised
from templates more sane, as it's consistent in or out of DEBUG, and you
can
catch the specific exception(s) you care about rather than having to
also catch
TemplateSyntaxError and unwrap it.
........
r16835 | julien | 2011-09-16 08:30:05 +0200 (Fr, 16 Sep 2011) | 1 line
Reverted the change in r16683, which, while fixing an alignment issue in
IE7 with the admin's "Save and continue editing" and "Save and add
another" buttons, caused the swapping of those buttons' order. Thanks to
jocmeh for the report. Refs #16852.
........
r16836 | carljm | 2011-09-16 12:53:15 +0200 (Fr, 16 Sep 2011) | 1 line
Fixed #16094 -- Added missing colon in custom permissions docs.
........
r16838 | carljm | 2011-09-16 13:12:35 +0200 (Fr, 16 Sep 2011) | 1 line
Fixed #16812 -- Percent-encode URLs in verify_exists, to fix test
failures on Python 2.5 and 2.6.
........
r16839 | carljm | 2011-09-16 13:57:03 +0200 (Fr, 16 Sep 2011) | 1 line
Fixed #16803 -- Use model verbose_name directly as ContentType unicode
representation so it can be translated. Thanks to bronger for the report
and Ivan Sagalaev for the patch.
........
r16840 | carljm | 2011-09-16 18:41:38 +0200 (Fr, 16 Sep 2011) | 1 line
Fixed #16568 -- Added RequireDebugFalse filter to prevent sending 500
error emails when DEBUG is True in projects with no explicit LOGGING
setting. Thanks to Andreas Pelme for report and patch.
........
r16841 | carljm | 2011-09-16 19:07:19 +0200 (Fr, 16 Sep 2011) | 1 line
Added release note and updated TEMPLATE_DEBUG documentation for r16833.
Thanks jezdez for the reminder.
........
r16842 | carljm | 2011-09-16 20:06:42 +0200 (Fr, 16 Sep 2011) | 9 lines
Fixed #16863 -- Corrected ReST markup to avoid errors building docs.
Although directives such as "note" and "warning" will accept content
immediately following the directive, this is technically where arguments
to the
directive should go (see http://sphinx.pocoo.org/rest.html#directives).
Putting
the content there means that any lines beginning with an inline text
role
(e.g. ":setting:`DEBUG`") will be mis-interpreted as an option block for
the
directive. To avoid this error, there should always be a blank line
between the
directive start and the directive content.
........
r16843 | jbronn | 2011-09-16 23:19:30 +0200 (Fr, 16 Sep 2011) | 1 line
Fixed #16864 -- WKT regex now allows negative SRIDs. Thanks, Marcel
Dancak for bug report and initial patch.
........
r16845 | jbronn | 2011-09-17 21:54:52 +0200 (Sa, 17 Sep 2011) | 1 line
Fixed #15277 -- Cleaned up `ogrinspect` command, added tests and
extended support beyond file-based OGR data sources. Thanks, willinoed
for bug report and jpaulett for initial patch.
........
r16846 | jbronn | 2011-09-17 22:06:00 +0200 (Sa, 17 Sep 2011) | 1 line
Updated the geographic admin to use OpenLayers 2.11.
........
r16847 | jbronn | 2011-09-18 01:01:46 +0200 (So, 18 Sep 2011) | 1 line
OpenLayers has had built-in OSM support since 2.10, no need for extra
JS.
........
r16848 | SmileyChris | 2011-09-18 06:09:44 +0200 (So, 18 Sep 2011) | 1
line
Fixes #8103 -- Select widget should only allow for one selected option
........
r16849 | julien | 2011-09-18 09:24:16 +0200 (So, 18 Sep 2011) | 1 line
Fixed #13211 -- Added the `Group` API reference and a `Permission` API
example to the `contrib.auth` documentation. Thanks to b14ck for the
report and to jpaulett and CrazyGir for the patch.
........
r16850 | julien | 2011-09-18 09:50:50 +0200 (So, 18 Sep 2011) | 1 line
Rectified the settings reference documentation to indicate that
`USE_L10N` (and not `USE_I18N`) controls the activation of locale-dictated
formats.
........
r16851 | julien | 2011-09-18 10:33:39 +0200 (So, 18 Sep 2011) | 1 line
Fixed #16676 -- Corrected the behavior of the 'add' template filter to
return an empty string instead of the given value unchanged in the case of
an invalid use. Thanks to dtrebbien for the report and to Aymeric Augustin
for the patch.
........
r16852 | PaulM | 2011-09-18 23:33:14 +0200 (So, 18 Sep 2011) | 2 lines
Removed an unused function definition.
........
r16853 | jbronn | 2011-09-19 00:28:17 +0200 (Mo, 19 Sep 2011) | 1 line
Updated geoadmin tests to reflect that OSM js is no longer required as
of r16847.
........
r16854 | julien | 2011-09-19 09:25:59 +0200 (Mo, 19 Sep 2011) | 1 line
Fixed #16659 -- Made the admin's date drilldown links in the changelist
have a variable width to play nicer with languages with long month names.
........
r16855 | julien | 2011-09-19 09:33:32 +0200 (Mo, 19 Sep 2011) | 1 line
Fixed #16876 -- Fixed a cross reference in the settings reference doc.
Thanks to Gumnos for the report.
........
r16856 | ramiro | 2011-09-20 20:16:49 +0200 (Di, 20 Sep 2011) | 11 lines
Improved test isolation of the admin tests and assigned custom admin
sites to
prevent test order dependant failures.
This involves introducing usage of `TestCase.urls` and implementing
proper
admin.py modules for some of the test apps.
Thanks Florian Apolloner for finding the issue and contributing the
patch.
Refs #15294 (it solves these problems so the fix for that ticket we are
going
to commit doesn't introduce obscure and hard to reproduce test failures
when
running the Django test suite.)
........
r16857 | ramiro | 2011-09-20 20:30:06 +0200 (Di, 20 Sep 2011) | 8 lines
Converted internal link generation in the admin and admin document
generator to use named URLs.
Thanks to Florian Apolloner for both the initial patch and his final
push to get
this fixed, to Dario Ocles for his great work on the admin templates and
switching the admin_doc application to also use named URLs, to Mikko
Hellsing
for his comments and to Jannis and Julien for their review and design
guidance.
Fixes #15294.
........
r16858 | DrMeers | 2011-09-21 03:33:14 +0200 (Mi, 21 Sep 2011) | 1 line
Fixed #16886 -- Memcached socket file documentation. Thanks ddbeck for
the report and patch.
........
r16860 | carljm | 2011-09-21 16:00:58 +0200 (Mi, 21 Sep 2011) | 1 line
Fixed #16838 -- Corrected broken add-another inline JS in admin with
related_name="+". Thanks jamesp for report and patch.
........
r16861 | carljm | 2011-09-21 16:20:18 +0200 (Mi, 21 Sep 2011) | 1 line
Fixed #16866 -- Clearer error message if empty list is passed to
select_template. Thanks Silver_Ghost for report and patch.
........
r16862 | jezdez | 2011-09-21 17:58:21 +0200 (Mi, 21 Sep 2011) | 1 line
Fixed the relative static file resolution of the
CachedStaticFilesStorage backend and the post processing of deeply nested
static files.
........
r16863 | jezdez | 2011-09-21 17:58:32 +0200 (Mi, 21 Sep 2011) | 1 line
Fixed #16703 -- Raise an exception if the storage location of the
DefaultStorageFinder is empty.
........
r16864 | julien | 2011-09-21 19:25:13 +0200 (Mi, 21 Sep 2011) | 1 line
Fixed #16897 -- Fixed some docstrings and help texts for the
`makemessages` management command. Thanks, Simon Meers.
........
r16865 | Alex | 2011-09-21 23:19:18 +0200 (Mi, 21 Sep 2011) | 1 line
Switch a few examples in the docs to use newstyle classes.
........
r16866 | DrMeers | 2011-09-22 00:43:41 +0200 (Do, 22 Sep 2011) | 1 line
Fixed #16904 -- Additional clarification regarding contrib.messages
iteration. Thanks murphyke for the report and patch.
........
r16868 | carljm | 2011-09-22 00:46:48 +0200 (Do, 22 Sep 2011) | 1 line
Fixed #16353 -- don't try to create Site objects on all databases. Refs
#15573, #15346. Thanks Aymeric Augustin for the report and the patch.
........
r16871 | PaulM | 2011-09-22 06:10:02 +0200 (Do, 22 Sep 2011) | 2 lines
Fixed #16907 -- Deprecate databrowse.
........
r16872 | PaulM | 2011-09-22 06:16:21 +0200 (Do, 22 Sep 2011) | 2 lines
Fixed #16837 -- Improved error message for admin login.
........
r16873 | PaulM | 2011-09-22 06:30:20 +0200 (Do, 22 Sep 2011) | 2 lines
Fixed #16026 -- loaddata now identifies which object triggered an error.
........
r16874 | PaulM | 2011-09-22 06:36:15 +0200 (Do, 22 Sep 2011) | 2 lines
Fixed #15633 -- Improved docs for post_syncdb signal.
........
r16875 | PaulM | 2011-09-22 06:52:43 +0200 (Do, 22 Sep 2011) | 2 lines
Fixed 11674 -- Clarified docs on excluded fields of ModelForms.
........
r16876 | PaulM | 2011-09-22 07:10:52 +0200 (Do, 22 Sep 2011) | 2 lines
Fixed #7198 -- Improved error message when missing models.py. Thanks
Silver_Ghost and for the patch.
........
r16877 | PaulM | 2011-09-22 07:21:51 +0200 (Do, 22 Sep 2011) | 2 lines
Fixed #6011 -- Improved help text for flush command. Thanks Julien for
the patch.
........
r16882 | PaulM | 2011-09-22 07:56:47 +0200 (Do, 22 Sep 2011) | 2 lines
Refs r16873 and #16026 -- Missed adding the fixture.
........
r16883 | PaulM | 2011-09-22 08:37:50 +0200 (Do, 22 Sep 2011) | 2 lines
Fixed #16565 -- Fixed a databrowse error on null foreign key, even
though databrowse is deprecated. Thanks aaugustin for the patch.
........
r16884 | jezdez | 2011-09-22 17:04:27 +0200 (Do, 22 Sep 2011) | 1 line
Fixed #16909 -- Pass language to get_format_modules when calling it from
get_format to make sure the correct module is returned.
........
r16885 | jezdez | 2011-09-22 17:04:34 +0200 (Do, 22 Sep 2011) | 1 line
Added versionadded directive for the `bulk_create` Queryset method
introduced in r16739.
........
r16886 | Alex | 2011-09-22 18:32:30 +0200 (Do, 22 Sep 2011) | 1 line
Slight english readability fix for the signals docs.
........
r16887 | ramiro | 2011-09-22 19:04:05 +0200 (Do, 22 Sep 2011) | 1 line
Fixed #16912 -- Fixed breadcrumb styling in a couple of admin pages,
broken since r16857. Thanks Florian Apolloner for the report.
........
r16888 | gabrielhurley | 2011-09-22 23:09:00 +0200 (Do, 22 Sep 2011) | 2
lines
Fixed #7198 (again) -- Corrects a problem with string interpolation from
r16876 and adds tests for the new error message.
........
r16889 | lukeplant | 2011-09-22 23:52:00 +0200 (Do, 22 Sep 2011) | 1
line
Fixed ReST errors that stopped some staticfiles docs being rendered
........
r16890 | PaulM | 2011-09-23 00:44:00 +0200 (Fr, 23 Sep 2011) | 2 lines
Fixed #16907 (again) -- Added deprecation of databrowse to the
deprecation docs.
........
r16893 | PaulM | 2011-09-23 01:03:53 +0200 (Fr, 23 Sep 2011) | 2 lines
Fixed #16910 -- Misleading regex in urlpatterns inclusion docs.
........
r16894 | PaulM | 2011-09-23 01:30:05 +0200 (Fr, 23 Sep 2011) | 2 lines
Fixed a typo in test docstring.
........
r16895 | carljm | 2011-09-23 06:22:30 +0200 (Fr, 23 Sep 2011) | 1 line
Fixed #16917 -- Don't try to use the model name for a ContentType's
unicode representation if the model no longer exists. Thanks Ivan Sagalaev
for report and patch.
........
r16896 | jacob | 2011-09-23 18:33:52 +0200 (Fr, 23 Sep 2011) | 1 line
Test commit - please ignore.
........
r16897 | jezdez | 2011-09-23 18:45:40 +0200 (Fr, 23 Sep 2011) | 1 line
Fixed #16878 -- Improved intword filter to support numbers up to
decillion and googol. Thanks to crodjer for the initial patch.
........
r16898 | ramiro | 2011-09-24 01:57:06 +0200 (Sa, 24 Sep 2011) | 5 lines
Removed unused code from admindocs app now that it supports reversing
URLs.
As a consequence the undocumented `ADMIN_SITE_ROOT_URL` setting isn't
used anymore.
Refs r8718 and r16857.
........
r16899 | julien | 2011-09-24 08:17:53 +0200 (Sa, 24 Sep 2011) | 1 line
Simplified the admin changelist multi-sort interface specifically by
removing the popup window, adding explicit tooltip help texts, improving
the hover visual states and allowing all operations (i.e. removing a
column from sorting and toggling the sorting with and without changing the
sorting priority) to be actionable with just one click. Many thanks to
Idan Gazit for the feedback and direction. Refs #16212.
........
r16900 | jezdez | 2011-09-24 15:32:57 +0200 (Sa, 24 Sep 2011) | 1 line
Fixed a regression introduced in r16897. Thanks to Julien for the eagle
eyes and Florian Apolloner for the review.
........
r16901 | ramiro | 2011-09-24 21:48:27 +0200 (Sa, 24 Sep 2011) | 4 lines
Fixed #16789 -- Added names to URLs in convenience contrib.auth urls.py.
Thanks wim AT go2people DOT nl for the report, cmheisel for the patch
and
fcurella for reviewing it.
........
r16902 | julien | 2011-09-25 07:21:29 +0200 (So, 25 Sep 2011) | 1 line
Fixed #16927 -- Corrected the `{% ifchanged %}` template tag's
documentation. Thanks to sebastian for the report and patch.
........
r16903 | ramiro | 2011-09-25 19:08:31 +0200 (So, 25 Sep 2011) | 3 lines
Fixed #16924 -- Corrected `date` template filter handling of negative
(West of UTC) timezone offsets.
The 'O' format specifier output was incorrect. Thanks mrgriscom and
Aymeric Augustin.
........
r16904 | ramiro | 2011-09-26 03:37:57 +0200 (Mo, 26 Sep 2011) | 3 lines
Fixed #16597 -- Added Sphinx cross-reference metadata to the form wizard
docs. Thanks FunkyBob for the report and jkistler for the patch.
Also, additional fixes in that document and in the WizardView
docstrings.
........
r16905 | Alex | 2011-09-26 12:11:18 +0200 (Mo, 26 Sep 2011) | 1 line
Fixed #16925 -- Make sure a signal is disconnected if the test fails.
Thanks to aaugustin for the patch.
........
r16906 | ramiro | 2011-09-26 13:24:38 +0200 (Mo, 26 Sep 2011) | 1 line
Tweaked the formwizard docs a bit more.
........
r16907 | lukeplant | 2011-09-26 19:20:20 +0200 (Mo, 26 Sep 2011) | 1
line
Removed unused parameter 'join_table' in various bits of RelatedManager
code
........
r16908 | julien | 2011-09-27 14:15:15 +0200 (Di, 27 Sep 2011) | 1 line
Fixed #13956 -- Enabled `*args` and `**kwargs` support for `simple_tag`,
`inclusion_tag` and `assignment_tag`. Many thanks to Stephen Burrows for
the report and initial patch, to Gregor Müllegger for the initial tests,
to SamBull for the suggestions, and to Jannis Leidel for the review and
PEP8 cleanup.
........
r16909 | julien | 2011-09-27 15:56:10 +0200 (Di, 27 Sep 2011) | 1 line
Brushed up the custom template tag 'howto' guide by moving the
assignment_tag doc to a more appropriate place (i.e. under the "Setting a
variable in the context" section), adding cross references, fixing a few
minor inaccuracies and doing a little PEP8 cleanup.
........
r16910 | PaulM | 2011-09-28 04:26:12 +0200 (Mi, 28 Sep 2011) | 2 lines
Fixed incorrect pluralized argument in Files docs
........
r16911 | julien | 2011-09-28 16:00:43 +0200 (Mi, 28 Sep 2011) | 1 line
Fixed #16949 -- Fixed a small typo in the GIS tutorial and also made
some minor PEP8 fixes and added some code-block directives while I was at
it. Thanks to jgomo3 for the report.
........
r16912 | lukeplant | 2011-09-29 17:30:19 +0200 (Do, 29 Sep 2011) | 1
line
Small cleanups of 'related manager' code for consistency
........
r16913 | lukeplant | 2011-09-29 17:30:29 +0200 (Do, 29 Sep 2011) | 7
lines
Cleanups to related manager code, especially in use of closures.
The related manager classes are defined within functions, and the
methods
had inconsistent and confusing usage of closures vs. parameters on self
to
retrieve needed information. Everything is stored on self now.
Also some methods were not using super() where they should have been.
........
r16914 | lukeplant | 2011-09-29 17:30:37 +0200 (Do, 29 Sep 2011) | 3
lines
Made GenericRelatedObjectManager consistent with other related managers
w.r.t. use of core_filters attribute.
Previously it had an unused keyword argument.
........
r16915 | jezdez | 2011-09-30 12:28:39 +0200 (Fr, 30 Sep 2011) | 1 line
Fixed doc references to `django.db.models.query.QuerySet` and converted
some tabs that were introduced in r16699 to spaces.
........
r16916 | lukeplant | 2011-09-30 12:41:25 +0200 (Fr, 30 Sep 2011) | 4
lines
Fixed #14270 - related manager classes should be cached
Thanks to Alex Gaynor for the report and initial patch, and mrmachine
for
more work on it.
........
r16917 | lukeplant | 2011-09-30 13:46:23 +0200 (Fr, 30 Sep 2011) | 8
lines
Fixed #16935 - misleading message if AttributeError escapes during
SimpleTemplateResponse.render
Thanks to isagalaev for the report.
As discussed on django-devs, this reverts some of the changes in [16568]
i.e. the addition of `SimpleTemplateResponse.__getattr__`, because this
makes it much harder to debug the common case of an AttributeError
somewhere
during the rendering of a SimpleTemplateResponse.
........
r16918 | ramiro | 2011-09-30 22:53:39 +0200 (Fr, 30 Sep 2011) | 6 lines
Fixed #8160 -- Made sure `modelformset_factory` takes in account
`fields' and `exclude` ModelForm options.
Thanks Andrew McMurry for the report and Claude Paroz for creating these
tests.
(Actually, this had been fixed in r10619 but the tests added then
exercise the
code in the context of ModelAdmin. This commit adds more generic tests.)
........
r16919 | ikelly | 2011-09-30 23:40:56 +0200 (Fr, 30 Sep 2011) | 1 line
Fixed #16645: fixed a broken test to work in Oracle.
........
r16920 | lukeplant | 2011-10-01 17:43:01 +0200 (Sa, 01 Okt 2011) | 1
line
Attempted to sort new features in 1.4 release notes into related topics
........
r16921 | ramiro | 2011-10-02 04:53:58 +0200 (So, 02 Okt 2011) | 5 lines
Fixed #10841 -- Switched response served when DEBUG=True and
request.is_ajax() returns True (indicating request has been generated by a
JS library) to a plain text version for easier debugging.
Contents of this response are similar to its HTML counterpart modulo
frame variables values in the Python traceback section.
Thanks to Riz for the report, to SmileyChris for the patch and to Julien
for reviewing.
........
r16922 | julien | 2011-10-03 10:06:01 +0200 (Mo, 03 Okt 2011) | 1 line
Added some sphinx cross-reference links to the built-in template tags
and filters in multiple areas of the documentation. Also fixed a few minor
inconsistencies and did a little PEP8 cleanup while I was at it.
........
r16923 | aaugustin | 2011-10-04 07:57:51 +0200 (Di, 04 Okt 2011) | 3
lines
Added self to committers.
........
r16924 | aaugustin | 2011-10-04 22:11:41 +0200 (Di, 04 Okt 2011) | 2
lines
Fixed #16971 - Made the parsing of javascript files by 'makemessages'
much faster. Thanks Antti Haapala for the implementation and Ned
Batchelder for the patch.
........
r16925 | Alex | 2011-10-05 01:54:12 +0200 (Mi, 05 Okt 2011) | 1 line
Fixed #16985 -- corrected a few grammar errors in the docs.
........
r16926 | PaulM | 2011-10-05 07:21:47 +0200 (Mi, 05 Okt 2011) | 2 lines
Fixed #16987 -- Improved error message for session tests. Thanks jMyles
and DiskSpace for the patch.
........
r16927 | lukeplant | 2011-10-05 11:54:01 +0200 (Mi, 05 Okt 2011) | 1
line
Very small docstring correction.
........
r16928 | julien | 2011-10-05 14:50:44 +0200 (Mi, 05 Okt 2011) | 1 line
Fixed #16990 -- Fixed a couple of small docstring typos in the
`django/test/testcases.py` module and did some minor cleanup while I was
in the area.
........
r16929 | lukeplant | 2011-10-06 00:56:09 +0200 (Do, 06 Okt 2011) | 5
lines
Fixed #16902 - select_related() results in a poor perfomance
Thanks to ivan_virabyan for the great patch!
(For the record, some very small tweaks were made by me).
........
r16930 | lukeplant | 2011-10-06 01:14:52 +0200 (Do, 06 Okt 2011) | 4
lines
Fixed #16937 - added `QuerySet.prefetch_related` to prefetch many
related objects.
Many thanks to akaariai for lots of review and feedback, bug finding,
additional unit tests and performance testing.
........
r16931 | lukeplant | 2011-10-06 13:08:11 +0200 (Do, 06 Okt 2011) | 4
lines
Removed ForeignRelatedObjectsDescriptor.RelatedManager.delete_manager,
which has been unused since [14507]
And cleaned up the result, allowing more consistency with the other
related
descriptors.
........
r16932 | carljm | 2011-10-06 19:31:18 +0200 (Do, 06 Okt 2011) | 1 line
Fixed #16988 - Clean up the deprecation timeline for language
consistency. Thanks ptone.
........
r16933 | aaugustin | 2011-10-06 22:39:15 +0200 (Do, 06 Okt 2011) | 3
lines
Fixed #16705 - Made the test client adhere to the WSGI spec -- in
particular, removed the assumption that environ['QUERY_STRING'] exists.
........
r16934 | carljm | 2011-10-07 02:41:25 +0200 (Fr, 07 Okt 2011) | 1 line
Fixed #8060 - Added permissions-checking for admin inlines. Thanks
p.patruno for report and Stephan Jaensch for work on the patch.
........
r16935 | aaugustin | 2011-10-07 10:35:20 +0200 (Fr, 07 Okt 2011) | 3
lines
Fixed #17012 - Removed references to the 'hasNoProfanities' validator.
Refs #8794.
........
r16936 | aaugustin | 2011-10-07 17:33:55 +0200 (Fr, 07 Okt 2011) | 2
lines
Fixed typo in r16935. Refs #17012.
........
r16937 | carljm | 2011-10-07 17:45:52 +0200 (Fr, 07 Okt 2011) | 1 line
Fixed #14678 -- Added validation to catch flatpages with the same URL on
the same site. Thanks seler for the report, and joni, graham_king, and
j4nu5 for work on the patch.
........
r16938 | carljm | 2011-10-07 17:48:30 +0200 (Fr, 07 Okt 2011) | 1 line
Corrected backwards middleware-ordering note in flatpage documentation.
........
r16939 | lukeplant | 2011-10-07 18:05:53 +0200 (Fr, 07 Okt 2011) | 3
lines
Fixed #17003 - prefetch_related should support foreign keys/one-to-one
Support for `GenericForeignKey` is also included.
........
r16940 | lukeplant | 2011-10-07 18:06:02 +0200 (Fr, 07 Okt 2011) | 7
lines
Fixed #17014 - added protection against infinite recursion.
Thanks to akaariai for the report and tests.
No tests have been added, since unittests for termination are basically
impossible, and the failure condition will take down the developer's
machine
in this case. It has been tested against the cases in #17014.
........
r16941 | aaugustin | 2011-10-07 18:52:58 +0200 (Fr, 07 Okt 2011) | 2
lines
Moved myself in the primary authors section.
........
r16942 | carljm | 2011-10-08 10:16:17 +0200 (Sa, 08 Okt 2011) | 1 line
Fixed #17011 - Made override_settings modify a decorated class in-place
rather than creating a dynamic subclass, so as to avoid infinite recursion
when used with super(). Thanks jsdalton for the report and patch.
........
r16943 | julien | 2011-10-08 13:36:05 +0200 (Sa, 08 Okt 2011) | 1 line
Made the tests introduced in r16942 use old-style class decoration to
run with Python < 2.6.
........
r16944 | lukeplant | 2011-10-08 15:50:29 +0200 (Sa, 08 Okt 2011) | 4
lines
More efficient IN clauses for prefetch_related queries by use of sets to
eliminate duplicates
This simply reduces the size of the IN clause in the SQL, which can be
significant in some cases.
........
r16945 | lukeplant | 2011-10-08 20:07:30 +0200 (Sa, 08 Okt 2011) | 1
line
Fixed some ReST errors in docs.
........
r16946 | carljm | 2011-10-08 21:23:37 +0200 (Sa, 08 Okt 2011) | 1 line
Fixed #16873 - Added dummy database backend in default settings, so that
just importing django.db doesn't trigger ImproperlyConfigured if there is
no DATABASES setting.
........
r16947 | julien | 2011-10-09 13:37:48 +0200 (So, 09 Okt 2011) | 1 line
Fixed #17019 -- Fixed a minor margin issue in multi-field admin form
rows for right-to-left languages. Thanks to rem for the report and patch.
........
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:33>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: simple_tag, | Triage Stage: Ready for
simpletag | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by pczerkas@…):
I think that one piece is still missing. How about allowing to pass
args/kwargs to templatetags:
{{{
{% some_tag named_args *args **kwargs %}
}}}
where args is a list, kwargs is a dict?
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Component: Template system | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* keywords: simple_tag, simpletag => simple_tag, simpletag, varargs
* status: closed => new
* resolution: fixed =>
* cc: pczerkas (added)
Comment:
Replying to [comment:33 pczerkas@…]:
> I think that one piece is still missing. How about allowing to pass
args/kwargs to templatetags:
> {{{
> {% some_tag named_args *args **kwargs %}
> }}}
> where args is a list, kwargs is a dict?
Patch for proposed functionality:
https://code.djangoproject.com/attachment/ticket/13956/13956.ttag_varargs_in_templates.1.diff
with tests.
The mailinglist discussion: https://groups.google.com/forum/#!topic
/django-developers/IU128CmM9Es
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:34>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Type: New feature | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: simple_tag, | Triage Stage: Ready for
simpletag, varargs | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by collinanderson):
Hi! Thanks for the patch. Could you open a separate ticket for this and
maybe link the two together because they're related?
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:35>
Django
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: julien
Component: Template system | Version: master
Keywords: simple_tag, | Triage Stage: Ready for
simpletag, varargs | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
--
Ticket URL: <https://code.djangoproject.com/ticket/13956#comment:36>